Skip to content

README: add link to musig example #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

theStack
Copy link
Contributor

@theStack theStack commented Jun 7, 2025

No description provided.

README.md Outdated
Comment on lines 154 to 156
* [MuSig2 Schnorr multi-signatures example](examples/musig.c)

To compile the Schnorr signature and ECDH examples, you also need to configure with `--enable-module-schnorrsig` and `--enable-module-ecdh`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, could you also fix the inconsistent sentence "To compile the ..."? Even before this PR it should also mention the ellswift module and --enable-module-ellswift. Maybe we can replace the sentence with something like this:

To compile the examples, make sure the corresponding modules are enabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, done.

@theStack theStack force-pushed the readme-mention_musig_example branch from c10f50c to 8192109 Compare June 16, 2025 14:54
Copy link
Contributor

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8192109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor/smell user-documentation user-facing documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants