Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: add instructions for verifying GPG signatures #1646

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

jamesob
Copy link
Contributor

@jamesob jamesob commented Dec 11, 2024

Fixes #1644.

@real-or-random real-or-random added the user-documentation user-facing documentation label Dec 11, 2024
Copy link
Contributor

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jamesob. I think this is a significant improvement to our README.

@jamesob jamesob force-pushed the jamesob-24-12-doc-gpg-verify branch from c850edd to f738f38 Compare December 13, 2024 21:10
@jamesob
Copy link
Contributor Author

jamesob commented Dec 13, 2024

@jonasnick I've pushed some changes based on your feedback, hope it helps.

@jamesob jamesob force-pushed the jamesob-24-12-doc-gpg-verify branch from f738f38 to 9180727 Compare February 4, 2025 04:26
@jamesob
Copy link
Contributor Author

jamesob commented Feb 4, 2025

Pushed a more succinct version that I think covers all feedback

Copy link
Contributor

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9180727

@jamesob jamesob force-pushed the jamesob-24-12-doc-gpg-verify branch from 9180727 to b682dbc Compare February 6, 2025 13:20
@sipa
Copy link
Contributor

sipa commented Feb 6, 2025

ACK b682dbc

Copy link
Contributor

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b682dbc

@jonasnick jonasnick merged commit 2e3bf13 into bitcoin-core:master Feb 10, 2025
116 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user-documentation user-facing documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPG signed verification of releases
4 participants