Skip to content

Fixes for integer precision loss #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 29, 2024
Merged

Fixes for integer precision loss #85

merged 3 commits into from
Apr 29, 2024

Conversation

theuni
Copy link
Contributor

@theuni theuni commented Apr 26, 2024 •
edited
Loading

These are the obvious naive fixes. I'll add comments for some of the alternatives that I see.

Fixes #84.

theuni
theuni commented Apr 26, 2024
View reviewed changes
sipa
sipa reviewed Apr 26, 2024
View reviewed changes
sipa
sipa reviewed Apr 26, 2024
View reviewed changes
@theuni theuni force-pushed the losing-my-precision branch 2 times, most recently from 9715057 to 37013f7 Compare April 26, 2024 19:47
@theuni theuni force-pushed the losing-my-precision branch from 37013f7 to 00fb4a4 Compare April 26, 2024 20:24
sipa
sipa reviewed Apr 26, 2024
View reviewed changes
src/minisketch.cpp
@@ -468,7 +468,7 @@ size_t minisketch_merge(minisketch* sketch, const minisketch* other_sketch) {
ssize_t minisketch_decode(const minisketch* sketch, size_t max_elements, uint64_t* output) {
const Sketch* s = (const Sketch*)sketch;
s->Check();
return s->Decode(max_elements, output);
return s->Decode(static_cast<int>(max_elements), output);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmpf. Unsure what to do with this.

It really means that max_elements cannot exceed 2^31-1 (or 2^16-1 on arcane platforms), which is likely the case in real use cases. But then again the API uses size_t and ssize_t which imply larger.

I guess we should leave this as-is for now, and then separately have a good look at what would be needed to make the internal code support (s)size_t-sized sketches.

@sipa
Copy link
Collaborator

sipa commented Apr 29, 2024

ACK 00fb4a4

@sipa sipa merged commit 7be08b8 into bitcoin-core:master Apr 29, 2024
21 checks passed
fanquake added a commit to fanquake/bitcoin that referenced this pull request Jun 12, 2024
@fanquake
Squashed 'src/minisketch/' changes from 3472e2f5ec..eb37a9b8e7
cb59af3 
eb37a9b8e7 Merge bitcoin-core/minisketch#87: Avoid copy in self-assign
fe6557642e Merge bitcoin-core/minisketch#88: build: Add `-Wundef`
8ea298bfa7 Avoid copy in self-assign
978a3d8869 build: Add `-Wundef`
3387044179 Merge bitcoin-core/minisketch#86: doc: fix typo in sketch_impl.h
15c2d13b60 doc: fix typo in sketch_impl.h
7be08b8a46 Merge bitcoin-core/minisketch#85: Fixes for integer precision loss
00fb4a4d83 Avoid or make integer precision conversion explicit
9d62a4d27c Avoid the need to cast/convert to size_t for vector operations
19e06cc7af Prevent overflows from large capacity/max_elements

git-subtree-dir: src/minisketch
git-subtree-split: eb37a9b8e79f9e49d73b96a49bf97a96d9eb676c
janus pushed a commit to BitgesellOfficial/bitgesell that referenced this pull request Jul 26, 2024
@fanquake @janus
Squashed 'src/minisketch/' changes from 3472e2f5ec..eb37a9b8e7
f4bfa21 
eb37a9b8e7 Merge bitcoin-core/minisketch#87: Avoid copy in self-assign
fe6557642e Merge bitcoin-core/minisketch#88: build: Add `-Wundef`
8ea298bfa7 Avoid copy in self-assign
978a3d8869 build: Add `-Wundef`
3387044179 Merge bitcoin-core/minisketch#86: doc: fix typo in sketch_impl.h
15c2d13b60 doc: fix typo in sketch_impl.h
7be08b8a46 Merge bitcoin-core/minisketch#85: Fixes for integer precision loss
00fb4a4d83 Avoid or make integer precision conversion explicit
9d62a4d27c Avoid the need to cast/convert to size_t for vector operations
19e06cc7af Prevent overflows from large capacity/max_elements

git-subtree-dir: src/minisketch
git-subtree-split: eb37a9b8e79f9e49d73b96a49bf97a96d9eb676c
vmta added a commit to umkoin/umkoin that referenced this pull request Oct 6, 2024
@vmta
Squashed 'src/minisketch/' changes from a223557ce..eb37a9b8e
21eb7a8 
eb37a9b8e Merge bitcoin-core/minisketch#87: Avoid copy in self-assign
fe6557642 Merge bitcoin-core/minisketch#88: build: Add `-Wundef`
8ea298bfa Avoid copy in self-assign
978a3d886 build: Add `-Wundef`
338704417 Merge bitcoin-core/minisketch#86: doc: fix typo in sketch_impl.h
15c2d13b6 doc: fix typo in sketch_impl.h
7be08b8a4 Merge bitcoin-core/minisketch#85: Fixes for integer precision loss
00fb4a4d8 Avoid or make integer precision conversion explicit
9d62a4d27 Avoid the need to cast/convert to size_t for vector operations
19e06cc7a Prevent overflows from large capacity/max_elements
3472e2f5e Merge bitcoin-core/minisketch#81: Avoid overflowing shift by special casing inverse of 1
653d8b2e2 Avoid overflowing shift by special casing inverse of 1
33b7c200b Merge bitcoin-core/minisketch#80: Add c++20 version of CountBits
4a48f31a3 Merge bitcoin-core/minisketch#83: ci: Fix "s390x (big-endian)" task
82b6488ac Add c++20 version of CountBits
0498084d3 ci: Fix "s390x (big-endian)" task
71709dca9 Merge bitcoin-core/minisketch#82: ci: Fix `x86_64-w64-mingw32` task
9e6127fa9 Merge bitcoin-core/minisketch#74: Avoid >> above type width in BitWriter
ed420bc17 ci: Fix `x86_64-w64-mingw32` task
fe1040f22 Drop -Wno-shift-count-overflow compile flag
154bcd43b Avoid >> above type width in BitWriter
67b87acdb Merge bitcoin-core/minisketch#78: ci: Update macOS image for CI
7de725041 ci: Update macOS image for CI
83d812ea9 Merge bitcoin-core/minisketch#73: ci: Use correct variable to designate C++ compiler
e051a7d69 ci: Install wine32 package for Windows tests
2d2c695d7 build: Drop unused `CC` variable
1810fcbd1 ci: Use correct variable to designate C++ compiler
022b95904 Merge bitcoin-core/minisketch#77: Add missing include
08443c489 Add missing include
a571ba20f Merge bitcoin-core/minisketch#68: Add missed `#include <string>`
b9a7f7e2b Merge bitcoin-core/minisketch#69: refactor: Drop unused `total` local variables
8a5af94ed Merge bitcoin-core/minisketch#70: build: Remove `-Qunused-arguments` workaround for clang + ccache
c36f1f03a Merge bitcoin-core/minisketch#72: Fix MSVC implementation of `CountBits()` function
0078bedda Ignore `HAVE_CLZ` macro when building with MSVC
1c772918c Fix MSVC implementation of `CountBits()` function
98f87c55f build: Remove `-Qunused-arguments` workaround for clang + ccache
11a1e25c8 refactor: Drop unused `total` local variables
ed6c8fcfd Add missed `#include <string>`
47f0a2d26 Merge bitcoin-core/minisketch#66: msvc: remove direct Bitcoin Core `compat.h` include
64f17584c msvc: remove Core compat.h include

git-subtree-dir: src/minisketch
git-subtree-split: eb37a9b8e79f9e49d73b96a49bf97a96d9eb676c
kwvg added a commit to kwvg/dash that referenced this pull request Oct 29, 2024
@kwvg
Squashed 'src/minisketch/' changes from 3472e2f5ec..eb37a9b8e7
ef10e83 
eb37a9b8e7 Merge bitcoin-core/minisketch#87: Avoid copy in self-assign
fe6557642e Merge bitcoin-core/minisketch#88: build: Add `-Wundef`
8ea298bfa7 Avoid copy in self-assign
978a3d8869 build: Add `-Wundef`
3387044179 Merge bitcoin-core/minisketch#86: doc: fix typo in sketch_impl.h
15c2d13b60 doc: fix typo in sketch_impl.h
7be08b8a46 Merge bitcoin-core/minisketch#85: Fixes for integer precision loss
00fb4a4d83 Avoid or make integer precision conversion explicit
9d62a4d27c Avoid the need to cast/convert to size_t for vector operations
19e06cc7af Prevent overflows from large capacity/max_elements

git-subtree-dir: src/minisketch
git-subtree-split: eb37a9b8e79f9e49d73b96a49bf97a96d9eb676c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sipa sipa sipa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix or disable conversion warnings?
2 participants
@theuni @sipa