We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
By default, Xcode adds warnings for implicit conversions that lose precision like: Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'uint32_t' (aka 'unsigned int')
Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'uint32_t' (aka 'unsigned int')
Noticed when testing the XCode output of #75. There are 10 instances of this and it's pretty annoying in the build logs.
For example:
size_t ComputeCapacity(uint32_t bits, size_t max_elements, uint32_t fpbits) { if (bits == 0) return 0; uint64_t base_fpbits = BaseFPBits(bits, max_elements);
Is there any interest in cleaning these up? Or would it be preferred to disable them with -Wconversion ?
-Wconversion
The text was updated successfully, but these errors were encountered:
I'm ok with adding explicit conversions to avoid these.
Sorry, something went wrong.
Quick naive fixes here. Want me to clean them up and PR?
7be08b8
Successfully merging a pull request may close this issue.
By default, Xcode adds warnings for implicit conversions that lose precision like:
Implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'uint32_t' (aka 'unsigned int')
Noticed when testing the XCode output of #75. There are 10 instances of this and it's pretty annoying in the build logs.
For example:
Is there any interest in cleaning these up? Or would it be preferred to disable them with
-Wconversion
?The text was updated successfully, but these errors were encountered: