cherry-pick: Remove leveldb::port::kLittleEndian. #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang 10 includes the optimizations described in https://bugs.llvm.org/show_bug.cgi?id=41761. This means that the platform-independent implementations of {Decode,Encode}Fixed{32,64}() compile to one instruction on the most recent Clang and GCC. PiperOrigin-RevId: 306330166
|
Would it be an alternative to sync all commits with upstream? |
dergoegge
approved these changes
Jan 15, 2025
|
cherry-pick ACK 2e3c013, but no strong opinion This is just a code-cleanup patch, but I wonder if they are worth it, given that other code changes won't be pulled in unless there is a full upstream pull. |
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Jan 16, 2025
04b5790928 Merge bitcoin-core/leveldb-subtree#46: Fix invalid pointer arithmetic in Hash (bitcoin#1222) 59669817c5 Merge bitcoin-core/leveldb-subtree#40: cherry-pick: Remove leveldb::port::kLittleEndian. 73013d1a37 Merge bitcoin-core/leveldb-subtree#45: [jumbo] Add begin()/end() to Slice. a8844b23ab Fix invalid pointer arithmetic in Hash (bitcoin#1222) be4dfc94b3 [jumbo] Add begin()/end() to Slice. 2e3c0131d3 Remove leveldb::port::kLittleEndian. git-subtree-dir: src/leveldb git-subtree-split: 04b57909285c7335c1908d53bcde9b90fe0439be
fanquake
added a commit
to bitcoin/bitcoin
that referenced
this pull request
Jan 21, 2025
910a11f build: remove LEVELDB_IS_BIG_ENDIAN (fanquake) d336b7a Squashed 'src/leveldb/' changes from 688561cba8..04b5790928 (fanquake) Pull request description: Includes: * bitcoin-core/leveldb-subtree#40 (used in #29852) * bitcoin-core/leveldb-subtree#45 * bitcoin-core/leveldb-subtree#46 ACKs for top commit: kevkevinpal: Concept ACK [910a11f](910a11f) l0rinc: ACK 910a11f hebasto: ACK 910a11f, I've performed a subtree update locally and got the same changes. theuni: utACK 910a11f Tree-SHA512: c5a2224c67d3fd598bc682589b805c324abf91003032a85764766048030285f56154779f29d3f0b3673c8f7f497ae62de5fc6b95ef0b022c873750053c7d27d5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang 10 includes the optimizations described in https://bugs.llvm.org/show_bug.cgi?id=41761. This means that the platform-independent implementations of {Decode,Encode}Fixed{32,64}() compile to one instruction on the most recent Clang and GCC.
PiperOrigin-RevId: 306330166
Cherry-picked from upstream: google@201f522.
Currently part of bitcoin/bitcoin#29852.