Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
33a28e2 Change default help arg to `-help` and mention `-h` and `-?` as alternatives (Lőrinc) f0130ab doc: replace `-?` with `-h` for bench_bitcoin help (Lőrinc) Pull request description: The question mark is interpreted as a wildcard for any single character in Zsh (see https://www.techrepublic.com/article/globbing-wildcard-characters-with-zsh), so `bench_bitcoin -?` will not show the help message on systems using Zsh, such as macOS. Since `-h` provides equivalent help functionality (as defined in https://github.com/bitcoin/bitcoin/blob/master/src/common/args.cpp#L684-L693), the `benchmarking.md` documentation has been updated to ensure compatibility with macOS. ---- ### -? > % cmake -B build -DBUILD_BENCH=ON && cmake --build build && build/src/bench/bench_bitcoin -? zsh: no matches found: -? ### -h > % cmake -B build -DBUILD_BENCH=ON && cmake --build build && build/src/bench/bench_bitcoin -h Usage: bench_bitcoin [options] Options: ... ---- Based on the comments the args help default was also changed to `-help`, mentioning `-h` and `-?` (instead of `-?` being the default) ACKs for top commit: edilmedeiros: tACK 33a28e2 maflcko: lgtm ACK 33a28e2 achow101: ACK 33a28e2 rkrux: tACK bitcoin/bitcoin@33a28e2 laanwj: Code review ACK 33a28e2 Tree-SHA512: 8c6e27488462be9ba9186b34abe6249c1d93026b3963acc0f42c75496f39407563766ae518cf1839156039cc0047e29d91f70d191cfb97e0fbde85665e88c71e
- Loading branch information