Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ledger udev rules and model IDs #746

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

bigspider
Copy link
Contributor

@bigspider bigspider commented Jul 15, 2024

Updated as per https://github.com/LedgerHQ/udev-rules/blob/f474382e370c9fa2a2207e6e675b9b364441aed7/20-hw1.rules, with more generic rules and including support for Ledger Stax and Flex.

Also added the corresponding device IDs for hwi enumerate.

@craigraw
Copy link

@bigspider It's probably a different PR, but would there need to be an additions to the map of LEDGER_MODEL_IDS

LEDGER_MODEL_IDS = {
0x10: "ledger_nano_s",
0x40: "ledger_nano_x",
0x50: "ledger_nano_s_plus"
}
for Stax (and now Flex) support?

@bigspider bigspider changed the title Update Ledger udev rules Update Ledger udev rules and model IDs Aug 5, 2024
@bigspider
Copy link
Contributor Author

@bigspider It's probably a different PR, but would there need to be an additions to the map of LEDGER_MODEL_IDS

LEDGER_MODEL_IDS = {
0x10: "ledger_nano_s",
0x40: "ledger_nano_x",
0x50: "ledger_nano_s_plus"
}

for Stax (and now Flex) support?

Good catch, thank you! I think there's no reason to have two separate PRs: I added the IDs for Stax and Flex in b6e0d33. I tested locally that hwi enumerate correctly lists them.

@achow101
Copy link
Member

ACK b6e0d33

@achow101 achow101 merged commit 4f0c047 into bitcoin-core:master Aug 29, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants