trezor: add Trezor Safe 5 support #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
CI build failures are reported here trezor/trezor-firmware#3988 but the changes look good to me!
matejcik
force-pushed
the
matejcik/hwi-ts5
branch
from
42ed442
to
e114031
Compare
|
let's see if e114031 helps |
It did, nice! |
|
Tested this successfully with all related functions on Sparrow. |
|
@achow101 Hi! Can we have a merge of this PR and then a new release? Lots of third parties are waiting for this |
|
heads-up: during today i'll update the PR with a new model. Ideally I'll also try to fit in a "generic unrecognized Trezor" support. |
matejcik
force-pushed
the
matejcik/hwi-ts5
branch
from
e114031
to
bda9af7
Compare
this is already installed
matejcik
force-pushed
the
matejcik/hwi-ts5
branch
from
bda9af7
to
3f91b35
Compare
|
ACK 3f91b35 Did not test, but looks fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just updated definitions from upstream trezorlib