test/test_device: do not enforce a password #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the type in `HardwareWalletClient`, password is optional and can be `None`: ``` def __init__(self, path: str, password: Optional[str], expert: bool, chain: Chain = Chain.MAIN) -> None: ``` The test code also expects that it can be `None`, e.g.: https://github.com/bitcoin-core/HWI/blob/d774d65255e1e78ea4d97846c2b4d26a23febcfb/test/test_device.py#L140 The BitBox02 client in fact checks that it must be `None` and raises a `BadArgumentError` otherwise, as the BitBox02 does not accept any password/passphrase from the host: https://github.com/bitcoin-core/HWI/blob/d774d65255e1e78ea4d97846c2b4d26a23febcfb/hwilib/devices/bitbox02.py#L266 Other devices like the Jade also don't take a host password/passphrase, and simply ignore the param. We could also do this for the BitBox02 (not raise any error if a password is supplied), but the right solution is to not enforce a password in the tests. This commit is in preparation of adding a BitBox02 simulator with tests.
|
@achow101 please check and merge. Or is there anyone else I should tag instead? I am not sure who is in the list of maintainers of this repo. Thanks. |
|
ACK 7fef64e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the type in
HardwareWalletClient, password is optional and can beNone:The test code also expects that it can be
None, e.g.:HWI/test/test_device.py
Line 140 in d774d65
The BitBox02 client in fact checks that it must be
Noneand raises aBadArgumentErrorotherwise, as the BitBox02 does not accept any password/passphrase from the host:HWI/hwilib/devices/bitbox02.py
Line 266 in d774d65
Other devices like the Jade also don't take a host password/passphrase, and simply ignore the param. We could also do this for the BitBox02 (not raise any error if a password is supplied), but the right solution is to not enforce a password in the tests.
This commit is in preparation of adding a BitBox02 simulator with tests.