List features #295
Open
List features #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achow101
force-pushed
the
list-features
branch
2 times, most recently
from
a2d60cf
to
3dc1eed
Compare
achow101
force-pushed
the
list-features
branch
5 times, most recently
from
2422cf1
to
3074bc1
Compare
|
needs rebase |
get_client_class gets the callable class for the given client name
Instead of saying "Ledger Nano S and X", give the correct name depending on whether the device model client is being used.
achow101
force-pushed
the
list-features
branch
from
2cda401
to
44140ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
getfeaturescommand to retrieve the feature support for a given device. The result of this should match the table in the README. To handle the 3 levels of support (supported, not supported by HWI, and not supported by device firmware), aDeviceFeatureenum is used. We can add more possible levels of support to this in the future. ASupportedFeaturesclass is also added to handle the support listing for a device so that we are sure that no feature is not listed for a given device.Because some device models that have the same type have different feature support, additional changes are made to have model specific
HWWClientclasses which will have their own feature listings. This will also make it easier in the future to do different things for different models if/when they diverge. In particular, this is used for Trezor 1 and Trezor T as Trezor T has some firmware bugs preventing it from having the same feature set as the Trezor 1.Closes #273