Skip to content

Remove VERSE from list of payment methods for creating new account#7590

Merged
HenrikJannsen merged 1 commit intobisq-network:masterfrom
HenrikJannsen:remove-verse-from-create-payment-account-list
Feb 17, 2026
Merged

Remove VERSE from list of payment methods for creating new account#7590
HenrikJannsen merged 1 commit intobisq-network:masterfrom
HenrikJannsen:remove-verse-from-create-payment-account-list

Conversation

@HenrikJannsen
Copy link
Collaborator

@HenrikJannsen HenrikJannsen commented Feb 17, 2026

Verse is not operating anymore.

Summary by CodeRabbit

  • Chores
    • Verse payment method has been removed from the application and is no longer available when managing fiat payment accounts.

Annotate it as deprecated.

Verse is not operating anymore.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
@coderabbitai
Copy link

coderabbitai bot commented Feb 17, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

This pull request deprecates the Verse payment method across the codebase by marking related classes and constants with @Deprecated annotations and filtering Verse from the available fiat payment methods in the UI.

Changes

Cohort / File(s) Summary
Payment Method Deprecation
core/src/main/java/bisq/core/payment/VerseAccount.java, core/src/main/java/bisq/core/payment/payload/VerseAccountPayload.java, core/src/main/java/bisq/core/payment/payload/PaymentMethod.java
Added @Deprecated annotations to VerseAccount and VerseAccountPayload classes, and introduced deprecated VERSE_ID constant, VERSE public field, and VERSE entry in PAYMENT_METHODS list with comments indicating Verse was shut down.
UI Filter Update
desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsView.java
Modified payment method filtering in addNewAccount to exclude Verse by ID (PaymentMethod.VERSE_ID) from available fiat payment options.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A Verse once danced through payment flows,
Now marked with @Deprecated, as it goes,
Filtered from the UI, gentle farewell,
Your shutdown story we'll forever tell,
Rest well, sweet method, your time has passed! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is minimal but contextually sufficient, explaining the reason (Verse is not operating anymore). However, it lacks details about the implementation approach and doesn't follow the template structure with issue references. Consider adding issue reference (Fixes #) and more details about the deprecation approach taken across the codebase for better clarity.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing VERSE from the payment methods list for creating new accounts, which aligns with the core objective of the PR.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into master

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@HenrikJannsen HenrikJannsen merged commit 80f5ed8 into bisq-network:master Feb 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant