Add react-native-macos support #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @hsjoberg ! It looks good to me, but I'll need to test myself it does not break stuff for Catalyst and iOS builds. I see you marked your PR as a draft, are you to push additional changes into it? |
|
Hi @birdofpreyru. |
|
I tried iOS. It builds and works still, @birdofpreyru. |
|
Hi, any update? |
|
It now waits when I find a moment to test the PR. |
Ok Thanks! I'm using a patch for now (in my test, the PR is working fine) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I'm opening this PR to see if there is interest.
As seen by the old lib, react-native-macos should really be compatible just as-is with the iOS code as there's little to no difference between iOS and macOS regarding file system matters (in my experience at least).
The UI document picker however is different between the operating systems, so I've disabled
pickFile()for react-native-macos. Every API has not been tested. But for exampleRNFS.LibraryDirectoryPathworks without any issues.Closes #40.
Cheers!