Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjusted capturer log level and added arguments. #136

Closed
wants to merge 1 commit into from

Conversation

AlexPatrie
Copy link
Contributor

What new features does this PR implement?
Please summarize the features that this PR implements. As relevant, please indicate the issues that the PR closes.

  • Adds Optional default setting for StandardOutputCapturerLevel to Config object. Adjusted default setting from "c" to "python" (closes dependency on capturer #135)
  • Adds type annotations to functions

What bugs does this PR fix?
Please summarize the bugs that this PR fixes. As relevant, please indicate the issues that the PR closes.

  • Fixes frozen stdout and no-output issues like this one

How have you tested this PR?
Pytest, and self testing.

@sonarcloud
Copy link

sonarcloud bot commented May 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AlexPatrie AlexPatrie closed this May 8, 2023
@AlexPatrie AlexPatrie deleted the refactoring-capture-level branch May 9, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

dependency on capturer
1 participant