Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CellML 1.1 validation #111

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

CellML 1.1 validation #111

wants to merge 5 commits into from

Conversation

bilalshaikh42
Copy link
Contributor

@bilalshaikh42 bilalshaikh42 commented Apr 13, 2022 •
edited
Loading

What new features does this PR implement?
Add model validation for CellML 1.1

@bilalshaikh42 bilalshaikh42 force-pushed the cell_ml_1.1_validation branch 2 times, most recently from f6adda9 to 6c20327 Compare April 13, 2022 18:19
@bilalshaikh42 bilalshaikh42 changed the title Cell ml 1.1 validation CellML 1.1 validation Apr 13, 2022
@bilalshaikh42 bilalshaikh42 force-pushed the cell_ml_1.1_validation branch 2 times, most recently from e70cd13 to f619114 Compare April 13, 2022 20:18
@jonrkarr
Copy link
Member

Thanks for implementing 1.1 validation. Please add a test before merging this.

@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bilalshaikh42 bilalshaikh42 linked an issue Apr 13, 2022 that may be closed by this pull request
Add validation for CellML 1.1 #42
Open
@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrkarr jonrkarr Awaiting requested review from jonrkarr

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add validation for CellML 1.1
4 participants
@bilalshaikh42 @jonrkarr @eagmon @CodeByDrescher