Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating version of utils backend. #62

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Updating version of utils backend. #62

merged 1 commit into from
Apr 27, 2023

Conversation

AlexPatrie
Copy link
Contributor

Problem scenario
As there have been substantial updates to the utils module since the last configuration of bounds for biosimulators-copasi, running pip install biosimulators-copasi could potentially install an old version of biosimulators-utils. This could potentially effect something like: #56.


Addresses a need for the following:

An updated share dependency commonality.


What does this PR do?

Adjusts the required bounds for biosimulator-utils to be >= 0.1.175.


To Do PRIOR to merge

None.

@AlexPatrie AlexPatrie requested a review from jcschaff April 27, 2023 20:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AlexPatrie AlexPatrie requested a review from eagmon April 27, 2023 20:57
@jcschaff
Copy link
Member

Looks reasonable - maybe you could briefly comment on how you verified that it works after the upgrade, or if you are relying on the new Biosimulators Test Suite submission for verification. Just curious.

Copy link
Member

@jcschaff jcschaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - approved.
please add a comment about how the change is validated (e.g. tested it locally, or relying on BSTS to validate).

Copy link
Member

@jcschaff jcschaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesterday @CodeByDrescher updated biosimulators_utils to v0.1.177. Maybe you could try to use the latest version of biosimulators_utils in biosimulators_COPASI - or do you anticipate risk?

@AlexPatrie
Copy link
Contributor Author

Yesterday @CodeByDrescher updated biosimulators_utils to v0.1.177. Maybe you could try to use the latest version of biosimulators_utils in biosimulators_COPASI - or do you anticipate risk?

I think it would be safest to keep 0.1.175 as the lower bound especially considering the last bound was set to a much earlier version.

@AlexPatrie AlexPatrie merged commit 3e6ea22 into dev Apr 27, 2023
@AlexPatrie AlexPatrie deleted the update-utils-version branch April 27, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants