-
-
Notifications
You must be signed in to change notification settings - Fork 203
fix: fix bunx/pnpx commands to use correct Biome even when not installed #3886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -24,7 +24,7 @@ also available as a [standalone executable] that doesn't require Node.js. | |||
|
|
||||
| :::note[Version pinning] | ||||
| `-E` ensures that the package manager pins the version of Biome. See the | ||||
| [versioning page](/internals/versioning) | ||||
| [versioning page](/internals/versioning) | ||||
| for more information about [why pinning the version is important]. | ||||
| ::: | ||||
|
|
||||
|
|
@@ -73,43 +73,43 @@ npx @biomejs/biome check --write <files> | |||
| <TabItem label="pnpm" icon="pnpm"> | ||||
| <Code frame="none" code={` | ||||
| # Format all files | ||||
| pnpm exec biome format --write | ||||
| pnpx @biomejs/biome format --write | ||||
|
|
||||
| # Format specific files | ||||
| pnpm exec biome format --write <files> | ||||
| pnpx @biomejs/biome format --write <files> | ||||
|
|
||||
| # Lint and apply safe fixes to all files | ||||
| pnpm exec biome lint --write | ||||
| pnpx @biomejs/biome lint --write | ||||
|
|
||||
| # Lint files and apply safe fixes to specific files | ||||
| pnpm exec biome lint --write <files> | ||||
| pnpx @biomejs/biome lint --write <files> | ||||
|
|
||||
| # Format, lint, and organize imports of all files | ||||
| pnpm exec biome check --write | ||||
| pnpx @biomejs/biome check --write | ||||
|
|
||||
| # Format, lint, and organize imports of specific files | ||||
| pnpm exec biome check --write <files> | ||||
| pnpx @biomejs/biome check --write <files> | ||||
| `} lang="bash" /> | ||||
| </TabItem> | ||||
| <TabItem label="bun" icon="bun"> | ||||
| <Code frame="none" code={` | ||||
| # Format all files | ||||
| bunx biome format --write | ||||
| bunx --bun @biomejs/biome format --write | ||||
|
|
||||
| # Format specific files | ||||
| bunx biome format --write <files> | ||||
| bunx --bun @biomejs/biome format --write <files> | ||||
|
|
||||
| # Lint and apply safe fixes to all files | ||||
| bunx biome lint --write | ||||
| bunx --bun @biomejs/biome lint --write | ||||
|
|
||||
| # Lint files and apply safe fixes to specific files | ||||
| bunx biome lint --write <files> | ||||
| bunx --bun @biomejs/biome lint --write <files> | ||||
|
|
||||
| # Format, lint, and organize imports of all files | ||||
| bunx biome check --write | ||||
| bunx --bun @biomejs/biome check --write | ||||
|
|
||||
| # Format, lint, and organize imports of specific files | ||||
| bunx biome check --write <files> | ||||
| bunx --bun @biomejs/biome check --write <files> | ||||
|
Comment on lines
+97
to
+112
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not don't think we should use the
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This mirrors what is in
|
||||
| `} lang="bash" /> | ||||
| </TabItem> | ||||
| <TabItem label="deno" icon="deno"> | ||||
|
|
@@ -164,13 +164,13 @@ Biome is available as a first-party extension in your favorite editors. | |||
| - [IntelliJ](/guides/editors/first-party-extensions#intellij) | ||||
| - [Zed](/guides/editors/first-party-extensions#zed) | ||||
|
|
||||
| There are also [community extensions](/guides/editors/third-party-extensions) | ||||
| for other editors, such as **Vim**, **Neovim**, and **Sublime Text**, to name | ||||
| There are also [community extensions](/guides/editors/third-party-extensions) | ||||
| for other editors, such as **Vim**, **Neovim**, and **Sublime Text**, to name | ||||
| a few. | ||||
|
|
||||
| ### Continuous Integration | ||||
|
|
||||
| Run `biome ci` as part of your CI pipeline to enforce code quality and consistency | ||||
| Run `biome ci` as part of your CI pipeline to enforce code quality and consistency | ||||
| across your team. It works just like the `biome check` command, but is optimized for | ||||
| CI environments. | ||||
|
|
||||
|
|
||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -24,7 +24,7 @@ również dostępny jako [samodzielny plik wykonywalny], który nie wymaga Node. | |||||||||||||||||||
|
|
||||||||||||||||||||
| :::note[Przypinanie wersji] | ||||||||||||||||||||
| `-E` zapewnia, że menedżer pakietów przypnie wersję Biome. Zobacz | ||||||||||||||||||||
| [stronę o wersjonowaniu](/internals/versioning) | ||||||||||||||||||||
| [stronę o wersjonowaniu](/internals/versioning) | ||||||||||||||||||||
| aby uzyskać więcej informacji o tym, [dlaczego przypinanie wersji jest ważne]. | ||||||||||||||||||||
|
Comment on lines
25
to
28
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add the comma before “aby”. ✍️ Suggested fix-`-E` zapewnia, że menedżer pakietów przypnie wersję Biome. Zobacz
-[stronę o wersjonowaniu](/internals/versioning)
-aby uzyskać więcej informacji o tym, [dlaczego przypinanie wersji jest ważne].
+`-E` zapewnia, że menedżer pakietów przypnie wersję Biome. Zobacz
+[stronę o wersjonowaniu](/internals/versioning),
+aby uzyskać więcej informacji o tym, [dlaczego przypinanie wersji jest ważne].📝 Committable suggestion
Suggested change
🧰 Tools🪛 LanguageTool[typographical] ~27-~27: Przed tym spójnikiem stawiamy przecinek: "), aby". (BRAK_PRZECINKA_ZEBY) [typographical] ~28-~28: Znaków interpunkcyjnych nie stawia się na początku zdania. (ZNAK_INTERPUNKCYJNY_NA_POCZATKU_ZDANIA) 🤖 Prompt for AI Agents |
||||||||||||||||||||
| ::: | ||||||||||||||||||||
|
|
||||||||||||||||||||
|
|
@@ -73,43 +73,43 @@ npx @biomejs/biome check --write <files> | |||||||||||||||||||
| <TabItem label="pnpm" icon="pnpm"> | ||||||||||||||||||||
| <Code frame="none" code={` | ||||||||||||||||||||
| # Formatuj wszystkie pliki | ||||||||||||||||||||
| pnpm exec biome format --write | ||||||||||||||||||||
| pnpx @biomejs/biome format --write | ||||||||||||||||||||
|
|
||||||||||||||||||||
| # Formatuj określone pliki | ||||||||||||||||||||
| pnpm exec biome format --write <files> | ||||||||||||||||||||
| pnpx @biomejs/biome format --write <files> | ||||||||||||||||||||
|
|
||||||||||||||||||||
| # Lintuj i zastosuj bezpieczne poprawki do wszystkich plików | ||||||||||||||||||||
| pnpm exec biome lint --write | ||||||||||||||||||||
| pnpx @biomejs/biome lint --write | ||||||||||||||||||||
|
|
||||||||||||||||||||
| # Lintuj pliki i zastosuj bezpieczne poprawki do określonych plików | ||||||||||||||||||||
| pnpm exec biome lint --write <files> | ||||||||||||||||||||
| pnpx @biomejs/biome lint --write <files> | ||||||||||||||||||||
|
|
||||||||||||||||||||
| # Formatuj, lintuj i organizuj importy wszystkich plików | ||||||||||||||||||||
| pnpm exec biome check --write | ||||||||||||||||||||
| pnpx @biomejs/biome check --write | ||||||||||||||||||||
|
|
||||||||||||||||||||
| # Formatuj, lintuj i organizuj importy określonych plików | ||||||||||||||||||||
| pnpm exec biome check --write <files> | ||||||||||||||||||||
| pnpx @biomejs/biome check --write <files> | ||||||||||||||||||||
| `} lang="bash" /> | ||||||||||||||||||||
| </TabItem> | ||||||||||||||||||||
| <TabItem label="bun" icon="bun"> | ||||||||||||||||||||
| <Code frame="none" code={` | ||||||||||||||||||||
| # Formatuj wszystkie pliki | ||||||||||||||||||||
| bunx biome format --write | ||||||||||||||||||||
| bunx --bun @biomejs/biome format --write | ||||||||||||||||||||
|
|
||||||||||||||||||||
| # Formatuj określone pliki | ||||||||||||||||||||
| bunx biome format --write <files> | ||||||||||||||||||||
| bunx --bun @biomejs/biome format --write <files> | ||||||||||||||||||||
|
|
||||||||||||||||||||
| # Lintuj i zastosuj bezpieczne poprawki do wszystkich plików | ||||||||||||||||||||
| bunx biome lint --write | ||||||||||||||||||||
| bunx --bun @biomejs/biome lint --write | ||||||||||||||||||||
|
|
||||||||||||||||||||
| # Lintuj pliki i zastosuj bezpieczne poprawki do określonych plików | ||||||||||||||||||||
| bunx biome lint --write <files> | ||||||||||||||||||||
| bunx --bun @biomejs/biome lint --write <files> | ||||||||||||||||||||
|
|
||||||||||||||||||||
| # Formatuj, lintuj i organizuj importy wszystkich plików | ||||||||||||||||||||
| bunx biome check --write | ||||||||||||||||||||
| bunx --bun @biomejs/biome check --write | ||||||||||||||||||||
|
|
||||||||||||||||||||
| # Formatuj, lintuj i organizuj importy określonych plików | ||||||||||||||||||||
| bunx biome check --write <files> | ||||||||||||||||||||
| bunx --bun @biomejs/biome check --write <files> | ||||||||||||||||||||
| `} lang="bash" /> | ||||||||||||||||||||
| </TabItem> | ||||||||||||||||||||
| <TabItem label="deno" icon="deno"> | ||||||||||||||||||||
|
|
@@ -164,13 +164,13 @@ Biome jest dostępny jako oficjalne rozszerzenie w Twoich ulubionych edytorach. | |||||||||||||||||||
| - [IntelliJ](/guides/editors/first-party-extensions#intellij) | ||||||||||||||||||||
| - [Zed](/guides/editors/first-party-extensions#zed) | ||||||||||||||||||||
|
|
||||||||||||||||||||
| Dostępne są również [rozszerzenia społeczności](/guides/editors/third-party-extensions) | ||||||||||||||||||||
| dla innych edytorów, takich jak **Vim**, **Neovim** i **Sublime Text**, żeby wymienić | ||||||||||||||||||||
| Dostępne są również [rozszerzenia społeczności](/guides/editors/third-party-extensions) | ||||||||||||||||||||
| dla innych edytorów, takich jak **Vim**, **Neovim** i **Sublime Text**, żeby wymienić | ||||||||||||||||||||
| tylko kilka. | ||||||||||||||||||||
|
|
||||||||||||||||||||
| ### Ciągła integracja | ||||||||||||||||||||
|
|
||||||||||||||||||||
| Uruchom `biome ci` jako część swojego pipeline CI, aby wymuszać jakość kodu i spójność | ||||||||||||||||||||
| Uruchom `biome ci` jako część swojego pipeline CI, aby wymuszać jakość kodu i spójność | ||||||||||||||||||||
| w całym zespole. Działa tak samo jak polecenie `biome check`, ale jest zoptymalizowane dla | ||||||||||||||||||||
| środowisk CI. | ||||||||||||||||||||
|
|
||||||||||||||||||||
|
|
||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually correct, why was this changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For parity with the other methods.
pnpm execexpects the package to be in the workspace, butbunx,npx,pnpxwill download and run:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, however,
pnpxhas been deprecated in favour ofpnpm dlxThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to this SO answer by pnpm maintainer zkochan it's not deprecated anymore as of 2024.
Would you like me to change
pnpxes topnpm dlxes anyhow?