Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add ui tests #6

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

ci: add ui tests #6

wants to merge 11 commits into from
+296 −44

Conversation

nhedger
Copy link
Member

@nhedger nhedger commented Dec 16, 2023

No description provided.

@nhedger
Copy link
Member Author

nhedger commented Dec 16, 2023

These tests appear to fail for a similar reason on the main repo, so I'm guessing they've been broken for some time.

Do they still make sense @victor-teles? If so, could use your help on this one.

@victor-teles
Copy link
Contributor

@nhedger
We need to set up a license to get this working, We can use Biome's license from the open source program.

Basically we need to copy the license key file (idea.key, clion.key..) to build/idea-sandbox/config-uiTest directory

c/c @ematipico (Tagging you because we talked about this a while ago)

@victor-teles
Copy link
Contributor

First of all, we need to define which license to use 💲😁

@nhedger
Copy link
Member Author

nhedger commented Dec 16, 2023

Got it. Happy to share my license if that's what it takes

@nhedger nhedger added Waiting for response Waiting for a response from the author of the issue Needs discussion Needs a discussion to understand criteria and removed Waiting for response Waiting for a response from the author of the issue labels Dec 17, 2023
@victor-teles
Copy link
Contributor

@nhedger Lets use mine, I'll send to you in Discord

@nhedger
Copy link
Member Author

nhedger commented Dec 17, 2023

Tests are still failing despite having put the license at ./build/idea-sandbox/config-uiTest/idea.key, as the docs seemed to suggest. The log does not appear to say anything about the a missing license though.

@nhedger nhedger added Help wanted Extra attention is needed Needs discussion Needs a discussion to understand criteria Waiting for response Waiting for a response from the author of the issue and removed Needs discussion Needs a discussion to understand criteria Waiting for response Waiting for a response from the author of the issue labels Dec 18, 2023
@victor-teles
Copy link
Contributor

@nhedger In addition to this license issue, I'm also having a problem with the test code that blocks this PR.
I've opened an issue in the intellij-ui-test-robot repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhedger @victor-teles