Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove reformat action in favor of LSP reformatter #100

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: remove reformat action in favor of LSP reformatter #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f45b62
feat: Remove reformat action in favor of LSP reformatter
denbezrukov Nov 10, 2024
a01885f
add changelog
denbezrukov Nov 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

All notable changes to this project will be documented in this file.

## Unreleased

### Features

- Remove reformat action in favor of LSP reformatter

## 1.0.0

### Bug Fixes
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ pluginUntilBuild = 243.*

# IntelliJ Platform Properties -> https://plugins.jetbrains.com/docs/intellij/tools-gradle-intellij-plugin.html#configuration-intellij-extension
platformType = WS
platformVersion = 2024.1.1
platformVersion = 2024.2.4

# Plugin Dependencies -> https://plugins.jetbrains.com/docs/intellij/plugin-dependencies.html
# Example: platformPlugins = com.jetbrains.php:203.4449.22, org.intellij.scala:2023.3.27@EAP
Expand Down
45 changes: 0 additions & 45 deletions src/main/kotlin/com/github/biomejs/intellijbiome/actions/ReformatWithBiomeAction.kt
View file
Open in desktop

This file was deleted.

9 changes: 1 addition & 8 deletions src/main/resources/META-INF/plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
instance="com.github.biomejs.intellijbiome.settings.BiomeConfigurable"/>
<actionOnSaveInfoProvider id="BiomeOnSaveInfoProvider"
implementation="com.github.biomejs.intellijbiome.settings.BiomeOnSaveInfoProvider"
order="after FormatOnSaveInfoProvider, after EsLintOnSaveInfoProvider, before BuildOnSaveInfoProvider, before FileWatcherOnSaveInfoProvider, before UploadOnSaveInfoProvider"/>
order="after FormatOnSaveInfoProvider, after EsLintOnSaveInfoProvider, before FileWatcherOnSaveInfoProvider, before UploadOnSaveInfoProvider"/>
<actionOnSave id="BiomeCheckOnSaveAction"
implementation="com.github.biomejs.intellijbiome.actions.BiomeCheckOnSaveAction"
order="after FormatOnSaveAction, after ESLintActionOnSave"/>
Expand All @@ -67,13 +67,6 @@
topic="com.intellij.openapi.vfs.newvfs.BulkFileListener"/>
</projectListeners>
<actions>
<action id="ReformatWithBiomeAction" text="Reformat with Biome" class="com.github.biomejs.intellijbiome.actions.ReformatWithBiomeAction">
<add-to-group group-id="EditorPopupMenu" anchor="last"/>
<add-to-group group-id="ProjectViewPopupMenu" anchor="last"/>
<keyboard-shortcut keymap="$default" first-keystroke="ctrl alt shift P"/>
<keyboard-shortcut keymap="Mac OS X" first-keystroke="meta alt shift P"/>
<keyboard-shortcut keymap="Mac OS X 10.5+" first-keystroke="meta alt shift P"/>
</action>
<group
id="com.github.biomejs.intellijbiome.actions-group"
text="Biome"
Expand Down
Loading