Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] ScoringSheetViewer slider style and tooltip #7024

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ZanMervic
Copy link
Contributor

Issue

Fixes #6985

Description of changes
  • Changes to the slider styling to suggest the slider is not interactive.
  • Created a custom slider which ignores mouse events instead of disabling the default slider. By doing this, the tooltip should work on macOS.
Includes
  • Code changes
  • Tests
  • Documentation

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 88.35%. Comparing base (7be875f) to head (046bef0).

❌ Your patch check has failed because the patch coverage (40.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7024      +/-   ##
==========================================
- Coverage   88.36%   88.35%   -0.02%     
==========================================
  Files         332      332              
  Lines       73345    73364      +19     
==========================================
+ Hits        64813    64819       +6     
- Misses       8532     8545      +13     

@ajdapretnar
Copy link
Contributor

I like the change visually, but the tooltip doesn't work for me. Perhaps it is not necessary, since we see the exact probability below, but I kind like tooltips in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scoring Sheet Viewer: slider not working
2 participants