Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Save Data: fix when saving to different drives on Windows #7019

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

markotoplak
Copy link
Member

Issue

Fixes #7018

Includes
  • Code changes
  • Tests
  • Documentation

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.47%. Comparing base (8542122) to head (f995a0b).

❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7019      +/-   ##
==========================================
- Coverage   88.48%   88.47%   -0.02%     
==========================================
  Files         332      332              
  Lines       73334    73337       +3     
==========================================
- Hits        64890    64885       -5     
- Misses       8444     8452       +8     

@markotoplak markotoplak force-pushed the fix-windows-different-drives branch from e94ac2d to f995a0b Compare February 5, 2025 10:35
@markotoplak
Copy link
Member Author

I added some paths to owsavebase windows tests in the first commit. I've verified that they were able to reproduce the issue on Github Actions.

The modified code does not exhibit the same issue anymore.

@markotoplak markotoplak marked this pull request as ready for review February 5, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File save causes exception if the workflow and destination are not on the same filesystem
1 participant