Merge pull request #7011 from VesnaT/predictions_warning

Predictions: Hide missing target warning when not relevant
biolab · Feb 1, 2025 · 8542122 · 8542122
2 parents 091e88c + 1acd9d2
commit 8542122
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/Orange/widgets/evaluate/owpredictions.py b/Orange/widgets/evaluate/owpredictions.py
@@ -502,6 +502,7 @@ def _update_score_table_visibility(self):
         else:
             view.setVisible(False)
             self.Error.scorer_failed.clear()
+        self._set_errors()
 
     def _set_errors(self):
         # Not all predictors are run every time, so errors can't be collected
@@ -520,7 +521,8 @@ def _set_errors(self):
                              and p.results.probabilities is None))
             self.Warning.wrong_targets(inv_targets, shown=bool(inv_targets))
 
-            show_warning = numpy.isnan(self.data.Y).any() and self.predictors
+            show_warning = numpy.isnan(self.data.Y).any() and self.predictors \
+                and self.show_scores
             self.Warning.missing_targets(shown=show_warning)
         else:
             self.Warning.wrong_targets.clear()

diff --git a/Orange/widgets/evaluate/tests/test_owpredictions.py b/Orange/widgets/evaluate/tests/test_owpredictions.py
@@ -702,6 +702,11 @@ def test_missing_target_cls(self):
         self.assertFalse(self.widget.Warning.missing_targets.is_shown())
         self.assertFalse(self.widget.Error.scorer_failed.is_shown())
 
+        self.send_signal(self.widget.Inputs.predictors, model)
+        self.assertTrue(self.widget.Warning.missing_targets.is_shown())
+        self.widget.controls.show_scores.setChecked(False)
+        self.assertFalse(self.widget.Warning.missing_targets.is_shown())
+
     def test_missing_target_reg(self):
         mask = np.zeros(len(self.housing), dtype=bool)
         mask[::2] = True