Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix test_overlay #299

Merged
merged 2 commits into from
May 24, 2024
Merged

Conversation

ales-erjavec
Copy link
Collaborator

Issue

Tests fail with a segmentation fault when running under pytest>=8.2

Changes

  • Dispatch to super class setUp/tearDown in TestOverlay
  • Replace use of Mock in signal connection with QSignalSpy

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.67%. Comparing base (6967b60) to head (4a878c7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   76.63%   76.67%   +0.04%     
==========================================
  Files          99       99              
  Lines       21101    21101              
==========================================
+ Hits        16170    16179       +9     
+ Misses       4931     4922       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ales-erjavec ales-erjavec merged commit ac0d421 into biolab:master May 24, 2024
25 of 26 checks passed
@ales-erjavec ales-erjavec deleted the fixes/test-overlay branch May 24, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants