[FIX] read/write: (Un)pickle only on user confirmation #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
reviewed
Sep 28, 2020
| @@ -804,16 +1006,16 @@ def check(obj): | |||
| return all(map(check, obj)) | |||
There was a problem hiding this comment.
@ales-erjavec, on Friday I didn't yet realize that .ows files contain literals, not json. I am always a few (well, a many) steps behind. :|
The list of allowed sequences does not include sets. I suppose it's because there's no literal for an empty set. But could non-empty sets be allowed?
There was a problem hiding this comment.
No. It would need to be all sets or none at all.
ales-erjavec
force-pushed
the
readwrite-pickle-only-on-confirmation
branch
from
a69c669 to
a11e98a
Compare
ales-erjavec
force-pushed
the
readwrite-pickle-only-on-confirmation
branch
from
a11e98a to
ff42430
Compare
ales-erjavec
force-pushed
the
readwrite-pickle-only-on-confirmation
branch
from
ff42430 to
28847dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Pickle format is used in the serialization (as a fallback when parameters cannot be saved as a python literal).
Changes
When saving: warn and ask for confirmation when the saved workflow will contain unsafe content.
When loading: warn and ask for confirmation; optionally load only workflow structure without parameters.