Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for downloaded or old force fields #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PabloNA97
Copy link
Contributor

Newest AMBER force fields are saved as leaprc. files in the $AMBERHOME/dat/leap/cmd directory. To use them, it is simply enough to provide the biobb with the name of the force field file you want to use (ff_name) and then find the corresponding leaprc.ff_name file.

However one may want to use one of the older force fields contained in the ./oldff directory inside the previous folder or simply download another leaprc file and provide the path directly.

Therefore I think this new implementation is more general and would permit the use of additional force fields through the biobb :)

@adamhospital
Copy link
Contributor

Very nice!
Before merging though we need to replicate this new functionality to the rest of building blocks that have the same forcefield property (add_ions, solvate, linear_structure)
We will take a look.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants