Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] in tuple_record: clear() on type that models tuple-like #78

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

swewagner
Copy link

I tried to use biocpp-io in a project that requires C++23 and encountered an issue with the tuple_record. It implements the clear() function through std::apply.
Since C++23 std::apply needs the secound argument to be tuple-like (see here).
I think the proposed changes fix this and change nothing else.

@h-2
Copy link
Member

h-2 commented Mar 5, 2025

Thank you for the PR. It LGTM, however the CI seems to be broken (unrelatedly).

I will see whether I can fix the CI this week. If I don't merge this within the next two weeks, please ping me 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants