Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate taxa by summary data #208

Merged
merged 11 commits into from
May 10, 2016
Merged

Generate taxa by summary data #208

merged 11 commits into from
May 10, 2016

Conversation

squirrelo
Copy link
Contributor

This is the first of a few PRs to generate the needed data for interactivity on the american gut site.

This PR generates the taxa summaries for each of the summary metadata categories we have (bmi, age, etc) that are generated for the static plot.

@squirrelo
Copy link
Contributor Author

Getting the same odd error as #207 but the rest is passing.

@squirrelo squirrelo force-pushed the generate-taxa-by-summary branch 2 times, most recently from c88dce0 to c6ced91 Compare April 20, 2016 17:26
@squirrelo
Copy link
Contributor Author

Ready for review

@squirrelo
Copy link
Contributor Author

Ping @EmbrietteH @wasade @jwdebelius for review.

@EmbrietteH
Copy link
Contributor

I think it's good now regenerating what's in the static plot; in the future we may want to revisit adding capability to choose more categories...

"""
paths = copy(agenv.paths['collapsed']['notrim']['1k'])
out_dir = get_existing_path(
agenv.path['populated-templates']['result-taxa'])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be agenv.paths ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, fixed

@squirrelo
Copy link
Contributor Author

Comments addressed, ready to go.

@wasade
Copy link
Member

wasade commented May 5, 2016

Couple of small comments, 👍 otherwise

@squirrelo
Copy link
Contributor Author

png @ekopylova

@ekopylova
Copy link

Thanks, looks good!

@EmbrietteH EmbrietteH merged commit 3847ba9 into master May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants