Update phables to 1.4.1 #51043

BiocondaBot · 2024-09-30T09:59:30Z

Update phables: 1.4.0 → 1.4.1

Info	Link or Description
Recipe	`recipes/phables` (click to view/edit other files)
Summary	Phables: from fragmented assemblies to high-quality bacteriophage genomes
Home	https://github.com/Vini2/phables
Releases	https://github.com/Vini2/phables/tags
Recipe Maintainer(s)	@Vini2
Author	@Vini2

This pull request was automatically generated (see docs).

coderabbitai · 2024-09-30T09:59:38Z

📝 Walkthrough

Walkthrough

The pull request updates the meta.yaml file for the phables package, incrementing the version from 1.4.0 to 1.4.1. It modifies the source URL and updates the SHA256 checksum to correspond with the new version. The build configuration has been changed to set noarch to false, while the requirements, test command, and metadata in the about section remain unchanged. Additionally, a new entry has been added to skip a specific lint check.

Changes

File	Change Summary
recipes/phables/meta.yaml	- Version updated from `1.4.0` to `1.4.1` - SHA256 checksum updated from `09b843...` to `f456260...` - Build configuration changed from `noarch: python` to `noarch: false` - New entry added to skip lint check for `should_be_noarch_generic`

Possibly related PRs

Update gbintk to v1.0.0 #50961: The noarch attribute was changed from python to false, similar to the change made in the main PR for the phables package.
Update agfusion to 1.4.3 #51041: The SHA256 checksum was updated alongside a version increment, which parallels the changes made in the main PR for the phables package.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ee01068 and 606ff9b.

📒 Files selected for processing (1)

recipes/phables/meta.yaml (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

recipes/phables/meta.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Vini2 · 2024-09-30T10:02:43Z

Please don't merge this PR yet. I have to edit it to skip the Windows build.

Thanks!

mbhall88 · 2024-09-30T23:59:54Z

@Vini2 I have converted it to a draft so no one accidentally merges it. Convert it back when you are happy with your edits and I will approve.

Vini2 · 2024-10-01T00:42:17Z

Thanks @mbhall88! I've updated the recipe and now it's ready for review.

I followed the edits done in PR 50961 to skip the Windows build.

Vini2 · 2024-10-01T01:49:53Z

@BiocondaBot please add label

martin-g · 2024-10-03T07:59:23Z

recipes/phables/meta.yaml


 build:
  number: 0
-  noarch: python
+  noarch: false


What is the reason for this change ?
I see no arch specific binaries built by the recipe: #51124 (comment)

I only wanted to skip the Windows build as an environment created in phables uses fraggenescan and hmmer which only support linux and osx. These environments are created once phables is installed as it's a snakemake tool.

Is there a way to not allow Windows machines to install?

Normally you would use the build/skip entry if you want to skip windows. So, to skip windows, you would do

build: skip: True # [win]

Though it does also say that if you shouldn't use a preselector (e.g., # [win]) with noarch packages. So I think you would have to remove the noarch key within build

Bioconda does not build for Windows anyway. Only Linux and OSX are supported at the moment.

So what would be the best way to specify this in the recipe?

Honestly I do not see a better solution than the current one.
You want to avoid Windows users to try to install the package, so you dropped noarch.

If you decide to go back to noarch then you can tell the users that Bioconda does not support Windows. It is written at the very top of the home page (https://bioconda.github.io/):

NOTE: Bioconda supports only Linux (64-bit and AArch64) and macOS (x86_64 and ARM64)

Update phables to 1.4.1

ee01068

BiocondaBot added autobump Automatic Version Update new version labels Sep 30, 2024

mbhall88 marked this pull request as draft September 30, 2024 23:58

Vini2 added 2 commits October 1, 2024 09:36

Update meta.yaml

9c7be71

Merge branch 'master' into bump/phables

606ff9b

Vini2 marked this pull request as ready for review October 1, 2024 00:40

BiocondaBot added the please review & merge set to ask for merge label Oct 1, 2024

mencian merged commit 1c04060 into master Oct 1, 2024
7 checks passed

mencian deleted the bump/phables branch October 1, 2024 01:53

martin-g reviewed Oct 3, 2024

View reviewed changes

coderabbitai bot mentioned this pull request Oct 4, 2024

phables: add aarch64/arm64 builds #51124

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update phables to 1.4.1 #51043

Update phables to 1.4.1 #51043

BiocondaBot commented Sep 30, 2024 •

edited

Loading

coderabbitai bot commented Sep 30, 2024 •

edited

Loading

Walkthrough

Changes

Possibly related PRs

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Vini2 commented Sep 30, 2024

mbhall88 commented Sep 30, 2024

Vini2 commented Oct 1, 2024

Vini2 commented Oct 1, 2024

martin-g Oct 3, 2024

Vini2 Oct 4, 2024 •

edited

Loading

mbhall88 Oct 4, 2024 •

edited

Loading

mbhall88 Oct 4, 2024 •

edited

Loading

martin-g Oct 4, 2024

Vini2 Oct 4, 2024

martin-g Oct 4, 2024 •

edited

Loading

Update phables to 1.4.1 #51043

Update phables to 1.4.1 #51043

Conversation

BiocondaBot commented Sep 30, 2024 • edited Loading

coderabbitai bot commented Sep 30, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Vini2 commented Sep 30, 2024

mbhall88 commented Sep 30, 2024

Vini2 commented Oct 1, 2024

Vini2 commented Oct 1, 2024

martin-g Oct 3, 2024

Choose a reason for hiding this comment

Vini2 Oct 4, 2024 • edited Loading

Choose a reason for hiding this comment

mbhall88 Oct 4, 2024 • edited Loading

Choose a reason for hiding this comment

mbhall88 Oct 4, 2024 • edited Loading

Choose a reason for hiding this comment

martin-g Oct 4, 2024

Choose a reason for hiding this comment

Vini2 Oct 4, 2024

Choose a reason for hiding this comment

martin-g Oct 4, 2024 • edited Loading

Choose a reason for hiding this comment

BiocondaBot commented Sep 30, 2024 •

edited

Loading

coderabbitai bot commented Sep 30, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

Vini2 Oct 4, 2024 •

edited

Loading

mbhall88 Oct 4, 2024 •

edited

Loading

mbhall88 Oct 4, 2024 •

edited

Loading

martin-g Oct 4, 2024 •

edited

Loading