Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skder & skani: add linux-aarch64 build #48904

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

martin-g
Copy link
Contributor

@martin-g martin-g commented Jul 3, 2024

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g martin-g added the aarch64 Related to adding linux-aarch64 support label Jul 3, 2024
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
@martin-g martin-g changed the title skder: add linux-aarch64 build skder & skani: add linux-aarch64 build Jul 3, 2024
@martin-g
Copy link
Contributor Author

martin-g commented Jul 3, 2024

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built are ready for inspection:

Arch Package Zip File / Repodata CI Instructions
linux-64 skani-0.2.1-h919a2d8_1.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>
linux-64 skder-1.2.1-py310h84f13bb_1.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>
linux-64 skder-1.2.1-py311h2a4ad6c_1.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>
linux-64 skder-1.2.1-py312h28adbb1_1.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>
osx-64 skani-0.2.1-hfd5405d_1.tar.bz2 OSXArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the OSXArtifacts directory: conda install -c ./packages <package name>
osx-64 skder-1.2.1-py310h413c500_1.tar.bz2 OSXArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the OSXArtifacts directory: conda install -c ./packages <package name>
osx-64 skder-1.2.1-py311hc04bfe9_1.tar.bz2 OSXArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the OSXArtifacts directory: conda install -c ./packages <package name>
osx-64 skder-1.2.1-py312h979fc42_1.tar.bz2 OSXArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the OSXArtifacts directory: conda install -c ./packages <package name>
linux-aarch64 skani-0.2.1-h2c59f48_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/e731538f-dfc3-4735-9c08-648916ae0bdc/artifacts/0/tmp/artifacts/packages <package name>
linux-aarch64 skder-1.2.1-py310ha2e58cd_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/e731538f-dfc3-4735-9c08-648916ae0bdc/artifacts/0/tmp/artifacts/packages <package name>
linux-aarch64 skder-1.2.1-py311he45c0d9_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/e731538f-dfc3-4735-9c08-648916ae0bdc/artifacts/0/tmp/artifacts/packages <package name>
linux-aarch64 skder-1.2.1-py312hbd5ab74_1.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/e731538f-dfc3-4735-9c08-648916ae0bdc/artifacts/0/tmp/artifacts/packages <package name>

Docker image(s) built:

Package Tag CI Install with docker
skani 0.2.1--h919a2d8_1 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/skani:0.2.1--h919a2d8_1.tar.gz | docker load
skder 1.2.1--py310h84f13bb_1 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/skder:1.2.1--py310h84f13bb_1.tar.gz | docker load
skder 1.2.1--py311h2a4ad6c_1 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/skder:1.2.1--py311h2a4ad6c_1.tar.gz | docker load
skder 1.2.1--py312h28adbb1_1 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/skder:1.2.1--py312h28adbb1_1.tar.gz | docker load

@martin-g
Copy link
Contributor Author

martin-g commented Jul 3, 2024

mgrigorov in 🌐 euler-arm-22 in /tmp/skder/skani via 🅒 test123 took 3s 
❯ tar xvf skani-0.2.1-h2c59f48_1.tar.bz2                                                                                                                                                                   (test123) 
info/test/run_test.sh
info/run_exports.json
info/files
info/hash_input.json
info/index.json
info/recipe/build.sh
info/paths.json
info/recipe/meta.yaml.template
info/recipe/meta.yaml
info/recipe/conda_build_config.yaml
info/about.json
info/git
.crates.toml
.crates2.json
bin/skani

mgrigorov in 🌐 euler-arm-22 in /tmp/skder/skani via 🅒 test123 
❯ file bin/*                                                                                                                                                                                               (test123) 
bin/skani: ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, not stripped

mgrigorov in 🌐 euler-arm-22 in /tmp/skder/skani via 🅒 test123 
❯ ./bin/skani                                                                                                                                                                                              (test123) 
skani 0.2.1
fast, robust ANI calculation and database searching for metagenomic contigs and assemblies.

Quick ANI calculation:
skani dist genome1.fa genome2.fa

Memory-efficient database search:
skani sketch genomes/* -o database; skani search -d database query1.fa query2.fa ...

All-to-all comparison:
skani triangle genomes/*

USAGE:
    skani [SUBCOMMAND]

OPTIONS:
    -h, --help       Print help information
    -V, --version    Print version information

SUBCOMMANDS:
    dist        Compute ANI for queries against references fasta files or pre-computed sketch
                    files.
                    Usage: skani dist query.fa ref1.fa ref2.fa ... or use -q/--ql and -r/--rl
                    options.
    search      Search queries against a large pre-sketched database of reference genomes in a
                    memory efficient manner.
                    Usage: skani search -d sketch_folder query1.fa query2.fa ...
    sketch      Sketch (index) genomes.
                    Usage: skani sketch genome1.fa genome2.fa ... -o new_sketch_folder
    triangle    Compute a lower triangular ANI/AF matrix.
                    Usage: skani triangle genome1.fa genome2.fa genome3.fa ...
mgrigorov in 🌐 euler-arm-22 in /tmp/skder via 🅒 test123 took 3s 
❯ tar xvf skder-1.2.1-py310ha2e58cd_1.tar.bz2                                                                                                                                                              (test123) 
info/test/run_test.sh
info/run_exports.json
info/hash_input.json
info/recipe/build.sh
info/has_prefix
info/index.json
info/files
info/recipe/meta.yaml.template
info/licenses/LICENSE
info/recipe/meta.yaml
info/paths.json
info/recipe/conda_build_config.yaml
info/about.json
info/git
lib/python3.10/site-packages/skDER/util.py
lib/python3.10/site-packages/skDER/__init__.py
lib/python3.10/site-packages/skDER-1.2.1.dist-info/top_level.txt
lib/python3.10/site-packages/skDER-1.2.1.dist-info/INSTALLER
lib/python3.10/site-packages/skDER-1.2.1.dist-info/WHEEL
lib/python3.10/site-packages/skDER-1.2.1.dist-info/METADATA
lib/python3.10/site-packages/skDER-1.2.1.dist-info/RECORD
lib/python3.10/site-packages/skDER-1.2.1.dist-info/LICENSE
lib/python3.10/site-packages/skDER-1.2.1.dist-info/REQUESTED
lib/python3.10/site-packages/skDER/__pycache__/__init__.cpython-310.pyc
lib/python3.10/site-packages/skDER/__pycache__/util.cpython-310.pyc
lib/python3.10/site-packages/skDER-1.2.1.dist-info/direct_url.json
bin/cidder
bin/skder
bin/skDERcore
bin/skDERsum

mgrigorov in 🌐 euler-arm-22 in /tmp/skder via 🅒 test123 
❯ file bin/*                                                                                                                                                                                               (test123) 
bin/cidder:    a /opt/conda/conda-bld/skder_1719991480607/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold script, ASCII text executable, with very long lines (372)
bin/skder:     a /opt/conda/conda-bld/skder_1719991480607/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold script, ASCII text executable
bin/skDERcore: ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, not stripped
bin/skDERsum:  ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, not stripped

mgrigorov in 🌐 euler-arm-22 in /tmp/skder via 🅒 test123 
❯ ./bin/skDERsum                                                                                                                                                                                           (test123) 
Usage:
skDERsum <skani triangle edge listing file> <n50 listing file> <min ANI> <min AF>

LGTM!

@martin-g
Copy link
Contributor Author

martin-g commented Jul 3, 2024

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Jul 3, 2024
@bgruening bgruening merged commit 80c08bb into bioconda:master Jul 4, 2024
6 checks passed
@martin-g martin-g deleted the aarch64-skder branch July 4, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch64 Related to adding linux-aarch64 support please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants