-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plate Diagram #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
# mypy last because it's so slow | ||
- id: mypy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same conclusions in my own pre-commit
toolchains, fun to see us converging
with raises(AttributeError): | ||
Container().get_source_expressions() # type: ignore[misc,operator] | ||
with raises(AttributeError): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like to use match
kwarg to tighten up these assertions further, I have seen drift in errors with same type happen before
Also, feel free to ignore this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.pytest.org/en/7.1.x/reference/reference.html#pytest.raises thanks for the tip
Background and Links
Changes and Testing
Questions and Followup
x-data
to a big enough<div>
tag without pretty elaborate template overrides.