repuller la base - #2
Open
billybones79 wants to merge 1474 commits into
Open
Conversation
To not use a String to constantize anymore.
Update rubocop
This module is only used in Capistrano-Alchemy, where it has been included in AlchemyCMS/capistrano-alchemy#17.
These tasks were only necessary for the capistrano-alchemy gem, which now can do this without Alchemy's direct help.
The "scaffold" generator has been renamed to "install".
Remove references to nonexistent "scaffold" generator
Remove Tasks::Helper module
We want to programmatically specify which menu names are allowed through a YML file. This method makes the contents of this YML file available to the app.
This adds a sample menus.yml to the install generator.
This allows us to use the same partial for multi-language sites.
The name field on root nodes is not meant to be human-readable, but rather translated.
Fix test coverage reporting
to 5.12.1
Update Fontawesome
Programmatic menus
Add alchemy.test to development domains
This is the simplest serializer for a node.
This moves an node to a specified parent and a specified position.
This is a nice sorting library that works with trees.
This commit allows sorting of menus. We instantiate for each element in the tree one instance of Sortable.js, but - through the `group` option - allow dragging and dropping between each element. For this to work, all `ul` elements need to be present (otherwise we cannot drop a node below a list that does not have nodes yet). A little tricky was the correct behaviour of the `folded` button: It should only be displayed if there are any pages to fold. This is now accomplished through rendering the `+` and `-` buttons in Javascript, depending on how many elements are in each list after sorting. Additionally: The full node tree is now rendered on page load, and all manipulations manipulate the DOM. There are no nodes being inserted or deleted through sorting or folding.
I had to reimplement jQuery.on for this to work.
We'll need to use this elsewhere.
Now it also returns a bit of JSON about the toggled node.
With the Attachment.url_class it is a extension point for alternativ url classes (ie. for remote URLs from S3)
Persist rendered picture variants
* Move back to Travis CI This reverts commit 411fc9d. * Update codeclimate_test_reporter in travis.yml * Remove warnings from travis.yml * Update travis build matrix This with all supported Ruby and Rails versions * Set up travis jobs for rspec and jest specs * Skip coverage upload for Jest specs It is not trivial to merge the coverage with the RSpec coverage. Since we do not have much Jest specs yet, it is not worth it in the moment. * Adjust rails generators coverage filter We do not test generators and after we moved the generators out of the lib/rails folder we need to adjust the filter.
* Fix locked page tab language code alignment * Fix height of error page
* Remove usage of deprecated toolbar helper * Remove deprecated toolbar helper Use `content_for :toolbar` and the `toolbar_button` helper instead.
As JPG and JPEG are technically the same image we must not convert them.
Please use `slug` instead.
* Remove redirect_to_public_child flag and feature This has been deprecated in 5.0 and is not supported anymore. * Include locale redirect modules in pages controller Now that we do not have to take care of the public child redirect anymore we can move the rather simple logic into the controller again.
If an app mounts Alchemy at a non-root path we need to return that as prefix. Closes #1918
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Webpacker needs Node >= 10.17. Let's use the current LTS version of Node
We need to reset the page when ever we search, because the result set will be much smaller so pagination needs to be resetted.
* Update config.yml * Update config.yml * Update config.yml * fix spacin in comment * fix urls in documentation
Remove page from search form query
Instead of only using the alt_tag attribute of the essence picture this now supports passing the alt attribute via the html_options and adds a fallback to a humanized picture name. This ensures we always have an alt text for accessibility reasons.
Booleans should have two possible values. This is unproblematic for every Boolean except for the EssenceBoolean "value", where the default depends on whatever the user wants.
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
If no size is selected, database value should be unset to give layout/settings size priority again
Sizes can be used standalone or as part of srcset. If used for srcset standalone sizes selection has to be disabled as the data is incompatible
Useful eg for custom picture tag creation
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.