Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting activation_token in supported portals #219

Merged

Conversation

apricotbucket28
Copy link
Contributor

Allow manually setting the activation_token option for the OpenURI and DynamicLauncher.Launch portals.

I saw that #70 is opened but it also includes additional integration, while this just allows setting the token if we already got it from somewhere else (e.g. directly via the Wayland protocol)

(related commit: apricotbucket28/zed@15489a0)

Copy link
Owner

@bilelmoussaoui bilelmoussaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are at it, we should also expose the activation_token in the email portal

src/desktop/dynamic_launcher.rs Outdated Show resolved Hide resolved
@apricotbucket28 apricotbucket28 changed the title dyanmic_launcher, open_uri: Allow setting activation_token Allow setting activation_token in supported portals Jun 20, 2024
Copy link
Owner

@bilelmoussaoui bilelmoussaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

src/activation_token/mod.rs Outdated Show resolved Hide resolved
src/activation_token/mod.rs Outdated Show resolved Hide resolved
@bilelmoussaoui
Copy link
Owner

Thanks a lot!

@bilelmoussaoui bilelmoussaoui merged commit 29f2e1a into bilelmoussaoui:master Jun 20, 2024
6 checks passed
@apricotbucket28 apricotbucket28 deleted the activation-token branch June 20, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants