ci: enable sonarqube analysis for contributors #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianjuar
force-pushed
the
fix-sonar-for-contributors
branch
7 times, most recently
from
c04313c to
152222c
Compare
dianjuar
force-pushed
the
fix-sonar-for-contributors
branch
from
152222c to
86d6247
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
Issue Number: #671
What is the new behavior?
Adding a new workflow
sonar-pr.ymlfor SonarCloud analysis on successful PR runs. This new workflow is triggered byworkflow_run, which allows secrets to be shared with PR's from forked repos.Does this PR introduce a breaking change?
Other information
According to the documentation for
workflow_run, the workflow must be on the main branch. This requirement makes it impossible to test the new CI configuration. We need to merge this PR to see the results.