Repository navigation
docs: fix broken links on htmx.org - #4134
Open
SatvikMishra08 wants to merge 1 commit into
Open
SatvikMishra08 wants to merge 1 commit into
SatvikMishra08 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A few links on htmx.org currently go nowhere:
htmx:sseOpenrow links to/events#htmx:sseOpen, but that event isn't on the events page (it's documented by the SSE extension). Pointed it at@/extensions/sse.md#htmx-sseopen, where the heading actually lives.#most-recentanchor link, but the<h3>has noid, so the link doesn't jump anywhere. Addedid="most-recent".hx-ws/hx-sselinks go tohtmx.org/attributes/hx-ws/and/hx-sse/, which 404 now that those attributes are gone in htmx 2. Pointed them at the v1 docs (v1.htmx.org/attributes/...).[swapping](@attributes/hx-swap)is missing the/and.md, so Zola renders it as the relative URL/extensions/idiomorph/@attributes/hx-swap(404). Changed it to@/attributes/hx-swap.md.Corresponding issue: none (website-only fix)
Testing
Website-only change. I found these with a link check of the live htmx.org and confirmed each new target exists (the
htmx-sseopenid on /extensions/sse/, the v1 attribute pages return 200, andcontent/attributes/hx-swap.mdexists).Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded (n/a, website only)