feat: add clear command
#611
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyriab
commented
Feb 22, 2025
src/_hyperscript.js
Outdated
| runtime.implicitLoop(element, function (target) { | ||
| if (target === element) { | ||
| target.replaceChildren() | ||
| } else if (target.parentElement && target.parentElement === element.relativeToElement |
There was a problem hiding this comment.
I don't know if it's the right approach but that the only way I've found for the last test to pass.
Otherwise it would clear all
elements, even from the caller's parent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy,
Added a
clearcommand with tests and docs.Since this is my first contribution to the codebase, I'm sure I've missed some things or done something not the way you'd do it.
I'd appreciate any feedback if that's the case and will fix.
I didn't know if I had to it manually but I rebuilt and added the test to the release candidate and all that.
Cheerio