Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud #9

Merged
merged 10 commits into from
Jul 23, 2024
Merged

Cloud #9

merged 10 commits into from
Jul 23, 2024

Conversation

tpietzsch
Copy link
Member

@tpietzsch tpietzsch commented May 3, 2024

Switch SpimData basePath from File to URI.

There is now a method XmlIoAbstractSpimData.load(Reader, URI) that can be used to load a SpimData object from a pre-constructed Reader (for example reading from S3). The URI is the URI of the XML and is used to construct the base path URI.

ImgLoader XmlIos get the base path URI, with the default implementation falling back to File base path, which is what is implemented everywhere. But XmlIos can now override

T fromXml( final Element elem, final URI basePathURI, AbstractSequenceDescription< ?, ?, ? > sequenceDescription )

and construct relative paths that point to S3 etc.

@tpietzsch tpietzsch marked this pull request as ready for review July 23, 2024 14:20
@tpietzsch tpietzsch merged commit 66411e6 into master Jul 23, 2024
1 check passed
@tpietzsch tpietzsch deleted the cloud branch July 23, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant