Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch SpimData basePath from File to URI.
There is now a method
XmlIoAbstractSpimData.load(Reader, URI)
that can be used to load aSpimData
object from a pre-constructedReader
(for example reading from S3). The URI is the URI of the XML and is used to construct the base path URI.ImgLoader
XmlIo
s get the base path URI, with the default implementation falling back toFile
base path, which is what is implemented everywhere. ButXmlIo
s can now overrideand construct relative paths that point to S3 etc.