Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: bump to bigdataviewer-vistools-1.0.0-beta-34 #269

Conversation

axtimwalde
Copy link
Member

@axtimwalde axtimwalde commented Feb 6, 2024

  • remove VolatileSource in favor of the upstream VolatileSource

* rename VolatileView to WrappedVolatileView to remove conflict with
  upstream bigdataviewer-vistools
@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/updated-ngff-support-in-fiji-hdf5-n5-zarr-ome-ngff/91705/40

* remove VolatileSource in favor of the upstream VolatileSource
@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/updated-ngff-support-in-fiji-hdf5-n5-zarr-ome-ngff/91705/42

@NicoKiaru
Copy link
Collaborator

NicoKiaru commented Feb 8, 2024

I'm just wondering: in the VolatileSource from this repo (the old one), I made sure that VolatileViews.wrapAsVolatile was called only once.

With the new version, VolatileViews.wrapAsVolatile is called many many times. Could this be an issue ?

@NicoKiaru NicoKiaru merged commit 8bdf6df into bigdataviewer:master Feb 8, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants