start RealTransformedSource #133
Conversation
bogovicj
commented
Apr 13, 2022
bogovicj
commented
- needs new releases of imglib2 and imglib2-realtransform
* needs new releases of imglib2 and imglib2-realtransform
| @@ -152,10 +152,12 @@ | |||
| <dependency> | |||
| <groupId>net.imglib2</groupId> | |||
| <artifactId>imglib2</artifactId> | |||
| <version>5.13.1-SNAPSHOT</version> | |||
There was a problem hiding this comment.
We could override the property imglib2.version instead of adding this here.
https://github.com/scijava/pom-scijava/blob/4e69adda1c948f929bcd4d0bf7bb98a1a0e04387/pom.xml#L583
| </dependency> | ||
| <dependency> | ||
| <groupId>net.imglib2</groupId> | ||
| <artifactId>imglib2-realtransform</artifactId> | ||
| <version>3.1.3-SNAPSHOT</version> |
There was a problem hiding this comment.
Same as above. You could override imglib2-realtransform.version instead which could then be used from dependencies in the meantime.
https://github.com/scijava/pom-scijava/blob/4e69adda1c948f929bcd4d0bf7bb98a1a0e04387/pom.xml#L611
There was a problem hiding this comment.
agree, was lazy since both this and the above will both change after new releases.
may not even need the property if those new versions make it to pom-scijava before this gets merged. we'll see
| * | ||
| * @author John Bogovic | ||
| * | ||
| * @param <T> the type |
There was a problem hiding this comment.
Perhaps more specifically you mean the pixel type for bdv.viewer.Source?
| @Override | ||
| public VoxelDimensions getVoxelDimensions() | ||
| { | ||
| return source.getVoxelDimensions(); |
There was a problem hiding this comment.
Is it always the case that the transformed dimensions are the same as the source dimensions?
There was a problem hiding this comment.
good question. yes it's always the same, since it also defers getSourceTransform to the wrapped source. The transform should be though of as world coordinates to world coordinates (I should include this in the doc). thanks @mkitti !
