feat(payment): PI-3536 [FE] Deprecate Masterpass #3085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| new CouponActionCreator(new CouponRequestSender(requestSender)), | ||
| new CustomerStrategyActionCreator( | ||
| createCustomerStrategyRegistry(store, requestSender, locale), | ||
| createCustomerStrategyRegistry(store, requestSender), |
There was a problem hiding this comment.
@bc-wpietrzak is this change intended? if yes, why it's needed?
Contributor
Author
There was a problem hiding this comment.
In all the cases you've pointed out locale value was only used by Masterpass; with Masterpass gone, locale is no longer needed
|
|
||
| buttonActionCreator = new CheckoutButtonStrategyActionCreator( | ||
| createCheckoutButtonRegistry(store, createRequestSender(), createFormPoster(), 'en'), | ||
| createCheckoutButtonRegistry(store, createRequestSender(), createFormPoster()), |
There was a problem hiding this comment.
@bc-wpietrzak is removing locale here and in other tests intended?
| options?: CheckoutButtonInitializerOptions, | ||
| ): CheckoutButtonInitializer { | ||
| const { host, locale = 'en' } = options ?? {}; | ||
| const { host } = options ?? {}; |
vitalii-koshovyi
approved these changes
Nov 27, 2025
animesh1987
approved these changes
Nov 27, 2025
bc-ania
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Remove Masterpass-related code, as the provider is deprecated and can no longer be used.
Related checkout-js PR: bigcommerce/checkout-js#2711
Rollout/Rollback
Revert
Testing
Unit tests/CI