Skip to content

Conversation

@bc-dronov
Copy link
Contributor

@bc-dronov bc-dronov commented Oct 27, 2025

What/Why?

Increased payment button height on customer step to 40px

Rollout/Rollback

Revert PR

Testing

Manual testing
Screenshot 2025-10-28 at 15 18 41

Screenshot 2025-11-03 at 10 34 13

@bc-dronov bc-dronov force-pushed the feat/wallet_buttons_40_px branch from 76fa52e to ea8c358 Compare October 28, 2025 14:20
@bc-dronov bc-dronov marked this pull request as ready for review October 28, 2025 14:20
@bc-dronov bc-dronov requested review from a team as code owners October 28, 2025 14:20
@bc-dronov bc-dronov changed the title feat(payment): Stripe Link V2 button strategy SPIKE buy now flow feat(payment): customer step buttons height 40px Oct 28, 2025
Copy link
Contributor

@bc-wpietrzak bc-wpietrzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,3 +1,3 @@
const DefaultCheckoutButtonHeight = 36;
const DefaultCheckoutButtonHeight = 40;
Copy link
Contributor

@bc-peng bc-peng Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

36 was a design decision before.
I can ping the design team to review the changes.
Before that, could you please add mobile view screenshots to the PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I've added the screenshot

@bc-dronov bc-dronov merged commit e0b8f55 into master Nov 3, 2025
9 checks passed
@bc-dronov bc-dronov deleted the feat/wallet_buttons_40_px branch November 3, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants