feat(payment): Stripe Link V2 strategy added #2885
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-dronov
force-pushed
the
feat/stripe-link_v2-strategy
branch
3 times, most recently
from
fbd1c89 to
9d671d3
Compare
bc-dronov
force-pushed
the
feat/stripe-link_v2-strategy
branch
from
9d671d3 to
1f31fc5
Compare
PavlenkoM
reviewed
Jun 2, 2025
packages/stripe-integration/src/stripe-utils/stripe-script-loader.ts
Outdated
Show resolved
Hide resolved
packages/stripe-integration/src/stripe-ocs/stripe-link-v2-customer-strategy.ts
Outdated
Show resolved
Hide resolved
packages/stripe-integration/src/stripe-ocs/stripe-ocs-customer-initialize-options.ts
Outdated
Show resolved
Hide resolved
packages/stripe-integration/src/stripe-ocs/stripe-link-v2-customer-strategy.ts
Outdated
Show resolved
Hide resolved
packages/stripe-integration/src/stripe-ocs/stripe-link-v2-customer-strategy.ts
Outdated
Show resolved
Hide resolved
packages/stripe-integration/src/stripe-ocs/stripe-link-v2-customer-strategy.ts
Outdated
Show resolved
Hide resolved
packages/stripe-integration/src/stripe-ocs/stripe-link-v2-customer-strategy.ts
Outdated
Show resolved
Hide resolved
packages/stripe-integration/src/stripe-ocs/stripe-link-v2-customer-strategy.ts
Outdated
Show resolved
Hide resolved
PavlenkoM
approved these changes
Jun 3, 2025
| toResolvableModule, | ||
| } from '@bigcommerce/checkout-sdk/payment-integration-api'; | ||
|
|
||
| import StripeUPEScriptLoader from '../stripe-utils/stripe-script-loader'; |
There was a problem hiding this comment.
Suggested change
| import StripeUPEScriptLoader from '../stripe-utils/stripe-script-loader'; | |
| import { StripeScriptLoader } from '../stripe-utils'; |
| ) => { | ||
| return new StripeLinkV2CustomerStrategy( | ||
| paymentIntegrationService, | ||
| new StripeUPEScriptLoader(getScriptLoader()), |
There was a problem hiding this comment.
Suggested change
| new StripeUPEScriptLoader(getScriptLoader()), | |
| new StripeScriptLoader(getScriptLoader()), |
| @@ -154,7 +154,10 @@ export interface StripeElement { | |||
| * in addition to some Element-specific keys. | |||
| * https://stripe.com/docs/js/element/events/on_change?type=paymentElement | |||
| */ | |||
| on(event: 'change' | 'ready', handler: (event: StripeEventType) => void): void; | |||
| on( | |||
| event: 'change' | 'ready' | 'shippingaddresschange' | 'shippingratechange' | 'confirm', | |||
There was a problem hiding this comment.
Suggested change
| event: 'change' | 'ready' | 'shippingaddresschange' | 'shippingratechange' | 'confirm', | |
| event: StripeElementEvent, |
Comment on lines
625
to
660
| export interface StripeLinkV2Event { | ||
| value?: null; | ||
| address?: { | ||
| city?: string; | ||
| country?: string; | ||
| postal_code?: string; | ||
| state?: string; | ||
| }; | ||
| shippingRate?: StripeLinkV2ShippingRate; | ||
| elementType: string; | ||
| expressPaymentType: string; | ||
| resolve(data: StripeLinkV2EventResolveData): void; | ||
| } | ||
|
|
||
| export interface StripeLinkV2EventResolveData { | ||
| lineItems?: LineItem[]; | ||
| allowedShippingCountries?: string[]; | ||
| shippingAddressRequired?: boolean; | ||
| shippingRates?: StripeLinkV2ShippingRate[]; | ||
| billingAddressRequired?: boolean; | ||
| emailRequired?: boolean; | ||
| phoneNumberRequired?: boolean; | ||
| } | ||
|
|
||
| export interface StripeLinkV2ShippingRate { | ||
| id: string; | ||
| amount: number; | ||
| displayName: string; | ||
| } | ||
|
|
||
| export interface StripeLinkV2Options { | ||
| clientSecret?: string; | ||
| mode?: string; | ||
| currency?: string; | ||
| amount?: number; | ||
| } |
There was a problem hiding this comment.
In case if it is Stripe OCS + Link v2 specific interfaces, lets move it to stripe-ocs folder.
Create a file for such OCS specific interfaces stripe-ocs/stripe-ocs.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Added Stripe Link v2 customer strategy.
For now it works without onConfirm method, as it will be implemented together with backend.
Testing / Proof
443655094-7bda7daa-b030-4f96-9217-040006459bb9.mov
@bigcommerce/team-checkout @bigcommerce/team-payments