Add custom image loader for BigCommerce CDN #574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
bookernath
force-pushed
the
bc-cdn-images
branch
from
9ca0de7 to
b8df75e
Compare
|
This makes lighthouse worse because some of the CDN optimizations aren't working correctly. Looking into that... |
bookernath
force-pushed
the
bc-cdn-images
branch
from
b8df75e to
996cbe4
Compare
bookernath
force-pushed
the
bc-cdn-images
branch
from
996cbe4 to
c402bdb
Compare
bookernath
force-pushed
the
bc-cdn-images
branch
from
c402bdb to
777633e
Compare
bookernath
force-pushed
the
bc-cdn-images
branch
from
777633e to
78407f7
Compare
bookernath
force-pushed
the
bc-cdn-images
branch
from
78407f7 to
bc63567
Compare
bookernath
force-pushed
the
bc-cdn-images
branch
from
bc63567 to
5dc4dc9
Compare
|
bookernath
force-pushed
the
bc-cdn-images
branch
from
5dc4dc9 to
ed97789
Compare
bookernath
force-pushed
the
bc-cdn-images
branch
from
ed97789 to
2e544ad
Compare
bookernath
force-pushed
the
bc-cdn-images
branch
from
6899c07 to
e211221
Compare
bookernath
force-pushed
the
bc-cdn-images
branch
from
e211221 to
3e73d6c
Compare
bookernath
force-pushed
the
bc-cdn-images
branch
2 times, most recently
from
4bfdfee to
1e8963d
Compare
bookernath
force-pushed
the
bc-cdn-images
branch
from
1e8963d to
560b4fd
Compare
bookernath
force-pushed
the
bc-cdn-images
branch
from
4ef72ed to
4236558
Compare
bookernath
force-pushed
the
bc-cdn-images
branch
from
4236558 to
f372df2
Compare
bookernath
force-pushed
the
bc-cdn-images
branch
from
f372df2 to
03f3dc6
Compare
bookernath
force-pushed
the
bc-cdn-images
branch
from
c6bc97c to
9aea253
Compare
bookernath
force-pushed
the
bc-cdn-images
branch
from
9aea253 to
3794c13
Compare
bookernath
force-pushed
the
bc-cdn-images
branch
from
3794c13 to
d35218c
Compare
⚡️🏠 Lighthouse reportWe ran Lighthouse against the changes and produced this report. Here's the summary:
Lighthouse ran against https://catalyst-latest-nm78m4n8e-bigcommerce-platform.vercel.app/ |
|
Closing in favor of #701 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Adds a custom image loader to use images directly from the BigCommerce CDN
This allows for more optimal image loading and is a more generic solution that should work across hosts, and prevent wasteful double-processing of images by stacking CDNs.
Testing
Ensured images are coming from BC CDN where relevant, and other URLs are not interfered with:
