refactor(cli): refactor option parsing, create new channel #572
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
| - [ ] Channel Site Routes | ||
| - [ ] Check Active Storeront Limit | ||
| - [ ] Prompt Sample Data API for New Channels | ||
| - [ ] Yarn module resolution bug | ||
| - [ ] Write root `.vscode/settings.json` |
There was a problem hiding this comment.
These are now accounted for in the backlog, removing from README.
| let projectName; | ||
| let projectDir; | ||
| let storeHash = options.storeHash; | ||
| let accessToken = options.accessToken; | ||
| let channelId; | ||
| let customerImpersonationToken = options.customerImpersonationToken; |
There was a problem hiding this comment.
These values may be parsed from options, but typically need additional validation, formatting, etc. which is denoted below by the if (options.property) statements below
| const { packageManager, ghRef } = options; | ||
|
|
||
| const URLSchema = z.string().url(); | ||
| const sampleDataApiUrl = parse(options.sampleDataApiUrl, URLSchema); | ||
| const bigcommerceApiUrl = parse(`https://api.${options.bigcommerceHostname}`, URLSchema); | ||
| const bigcommerceAuthUrl = parse(`https://login.${options.bigcommerceHostname}`, URLSchema); |
There was a problem hiding this comment.
These values are parsed from options, and never need to be modified again (hence, the const declaration).
| import { Https } from './https'; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| export const checkStorefrontLimit = (bc: Https) => true; |
There was a problem hiding this comment.
Placeholder stub - will be completed as part of CATALYST-313
There was a problem hiding this comment.
PR for this is up: #573
| @@ -34,8 +34,12 @@ export const login = async ( | |||
| return { storeHash, accessToken }; | |||
| } | |||
|
|
|||
| const shouldLogin = await confirm({ | |||
| const shouldLogin = await select({ | |||
There was a problem hiding this comment.
Switched for consistency with other yes/no prompts.
matthewvolk
force-pushed
the
refactor/catalyst-315-319
branch
from
8a0c767 to
2feaf65
Compare
⚡️🏠 Lighthouse reportWe ran Lighthouse against the changes and produced this report. Here's the summary:
Lighthouse ran against https://catalyst-latest-cckbuvv5v-bigcommerce-platform.vercel.app/ |
matthewvolk
force-pushed
the
refactor/catalyst-315-319
branch
from
2feaf65 to
9599b62
Compare
matthewvolk
force-pushed
the
refactor/catalyst-315-319
branch
from
9599b62 to
1a774d1
Compare
What/Why?
This PR fixes two issues:
--project-namepotentially conflicting with another directory name in the target project directory.Testing
CI