Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): minimum node.js version check #557

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

matthewvolk
Copy link
Contributor

@matthewvolk matthewvolk commented Feb 14, 2024

What/Why?

Exits the Node.js process for the create-catalyst CLI if the user's Node version is not at least 18.

Testing

Screen.Recording.2024-02-14.at.12.03.33.PM.mov

@matthewvolk matthewvolk requested a review from a team as a code owner February 14, 2024 17:31
Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-core-kynz ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 6:05pm
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 6:05pm
catalyst-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 6:05pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Feb 14, 2024 6:05pm
catalyst-1millionproducts-store ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 6:05pm
catalyst-2000ms-api ⬜️ Ignored (Inspect) Feb 14, 2024 6:05pm
catalyst-ppr ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 6:05pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 6:05pm

@vercel vercel bot temporarily deployed to Preview – catalyst-core-kynz February 14, 2024 17:36 Inactive
packages/create-catalyst/src/index.ts Outdated Show resolved Hide resolved
Copy link
Contributor

⚡️🏠 Lighthouse report

We ran Lighthouse against the changes and produced this report. Here's the summary:

Category Score
🟢 Performance 95
🟢 Accessibility 95
🟠 Best practices 78
🟢 SEO 92

Lighthouse ran against https://catalyst-latest-5oe9jd35e-bigcommerce-platform.vercel.app/

@vercel vercel bot temporarily deployed to Preview – catalyst-core-kynz February 14, 2024 18:05 Inactive
@matthewvolk matthewvolk added this pull request to the merge queue Feb 14, 2024
Merged via the queue into main with commit 2ec3028 Feb 14, 2024
21 checks passed
@matthewvolk matthewvolk deleted the feat/cli-node-version-check branch February 14, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants