fix(core): show correct product card info #554
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
jorgemoya
changed the title
avattipalli
force-pushed
the
product-card-changes
branch
from
de584b4 to
79dc53a
Compare
| @@ -19,6 +19,7 @@ export default defineConfig({ | |||
| 'x-vercel-protection-bypass': process.env.VERCEL_PROTECTION_BYPASS, | |||
| 'x-vercel-set-bypass-cookie': process.env.CI ? 'true' : 'false', | |||
| }, | |||
| actionTimeout: 1000 | |||
There was a problem hiding this comment.
Can we avoid setting timeouts? This is usually a smell that points to something in our test or the storefront that we need to look into.
There was a problem hiding this comment.
This is required for the test which is verifying the cyclical behavior of Carousel. As there are multiple clicks that is refreshing the carousel items being displayed this was necessary.
I'm not sure why this is a bad practise? This isn't an explicit wait, right? We are waiting for the page/DOM loads to finish on actions we think will take time.
There was a problem hiding this comment.
It shouldn't be required for this test to work. The docs for this option even say that you should be looking elsewhere if the test is flaky:
If you happen to be in this section because your test are flaky, it is very likely that you should be looking for the solution elsewhere.
It should work without this option:
The actionTimeout option should be for something like a button that is asynchronously waiting for data to be fetched and is showing a loading state before clicking (which I think is actually being accounted for according to the docs), but timeouts in general should rarely be used as it's most likely a cause of something else.
There was a problem hiding this comment.
I was legit seeing the test fail locally once in a few runs but it seems to be working fine 🤷 . Remove it.
avattipalli
force-pushed
the
product-card-changes
branch
from
79dc53a to
8827372
Compare
avattipalli
force-pushed
the
product-card-changes
branch
from
8827372 to
87b96dd
Compare
avattipalli
force-pushed
the
product-card-changes
branch
from
87b96dd to
4533b32
Compare
⚡️🏠 Lighthouse reportWe ran Lighthouse against the changes and produced this report. Here's the summary:
Lighthouse ran against https://catalyst-latest-fv8rx90jz-bigcommerce-platform.vercel.app/ |
What/Why?
Testing
Locally