feat(core): Add env var to control default prefetch behavior #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
christensenep
force-pushed
the
add-prefetch-config
branch
from
78e16c0 to
959800e
Compare
deini
reviewed
Feb 14, 2024
.env.example
Outdated
| # Controls the default behavior of Link components when a `prefetch` prop is not provided. | ||
| # If set to `true`, Link components will default to `prefetch=true`. | ||
| # Otherwise, Link components will default to `prefetch=false`. | ||
| DEFAULT_PREFETCH_BEHAVIOR=false |
There was a problem hiding this comment.
We need to prefix this with NEXT_PUBLIC_
christensenep
force-pushed
the
add-prefetch-config
branch
from
959800e to
b7eacd3
Compare
⚡️🏠 Lighthouse reportWe ran Lighthouse against the changes and produced this report. Here's the summary:
Lighthouse ran against https://catalyst-latest-th6fst05a-bigcommerce-platform.vercel.app/ |
jorgemoya
reviewed
Feb 16, 2024
| @@ -9,8 +9,10 @@ type LinkType = Omit<React.AnchorHTMLAttributes<HTMLAnchorElement>, keyof LinkPr | |||
| children?: React.ReactNode; | |||
| } & React.RefAttributes<HTMLAnchorElement>; | |||
|
|
|||
| const prefetchDefault = process.env.DEFAULT_PREFETCH_BEHAVIOR === 'true'; | |||
There was a problem hiding this comment.
Suggested change
| const prefetchDefault = process.env.DEFAULT_PREFETCH_BEHAVIOR === 'true'; | |
| const prefetchDefault = process.env.NEXT_PUBLIC_DEFAULT_PREFETCH_BEHAVIOR === 'true'; |
Or does next remove NEXT_PUBLIC by default? 🤔
|
Going to close this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Adds support for the
DEFAULT_PREFETCH_BEHAVIORenvironment variable. If set totrue,Linkcomponents will default toprefetch=truewhen aprefetchprop is not provided. Otherwise, they will default toprefetch=false, which is the current behavior.Testing
Tested locally, verifying that prefetching is globally disabled when
DEEFAULT_PREFETCH_BEHAVIORis any value other thantrue, and enabled if it is set totrue.