Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable ppr in auth pages to make them SSG #1946

Open
wants to merge 2 commits into
base: canary
Choose a base branch
from

Conversation

jorgemoya
Copy link
Contributor

@jorgemoya jorgemoya commented Jan 31, 2025

What/Why?

Disables ppr by export const experimental_ppr = false; since there are no dynamic elements in these pages.

Before

Screenshot 2025-02-04 at 2 56 33 PM

After

Screenshot 2025-02-04 at 2 57 40 PM

Testing

Locally, behavior works the same, but during build time the page is SSG.

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-canary ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 9:02pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Feb 4, 2025 9:02pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 9:02pm
catalyst-soul ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 9:02pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 9:02pm

Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: 8099817

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jorgemoya jorgemoya changed the title fix: disable ppr in auth pages to make them build statically fix: disable ppr in auth pages to make them SSG Feb 4, 2025
@jorgemoya jorgemoya marked this pull request as ready for review February 4, 2025 20:59
@jorgemoya jorgemoya requested a review from a team as a code owner February 4, 2025 20:59
Copy link
Contributor

github-actions bot commented Feb 4, 2025

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-canary-nhwwo8g9o-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 99
🟢 Accessibility 92
🟠 Best practices 78
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 86
🟢 Accessibility 92
🟠 Best practices 78
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant