-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Error page and ErrorBoundary #1827
base: soul/main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Do we have a way to test this?
0d8ef37
to
b770b9e
Compare
@migueloller I tested on my sandbox store, since my category pages are still returning 500 errors due to that weird If we were to make functional tests for this behavior though, not entirely sure how we'd go about testing - we'd have to force an internal error. |
We should be able to do this by passing a streamable prop that throws whenever we implement the test |
@migueloller Yeah, that's what I had in mind also. For a functional / E2E test though, not sure how we'd force the error there 💭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Having two error boundaries makes sense, even though we duplicate code, which seems off.
b770b9e
to
4c6a574
Compare
4c6a574
to
e6a72b8
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-j00f6pyzu-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
e6a72b8
to
02eced4
Compare
What/Why?
Error
component from VIBESerror
page to use this component(default)
route to maintain layout structure when error occursTesting