Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add props and css variables to Slideshow #1758

Merged
merged 2 commits into from
Dec 17, 2024
Merged

feat: add props and css variables to Slideshow #1758

merged 2 commits into from
Dec 17, 2024

Conversation

apledger
Copy link

What/Why?

Added props to Slideshow:

  • playOnInit
  • showDescription
  • showCta
  • variant, size, and shape to cta

Added css variables to Slideshow for future theming.

Testing

Verified on homepage.

CleanShot 2024-12-15 at 18 22 24@2x

@apledger apledger requested a review from a team as a code owner December 15, 2024 23:22
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a0305c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 3:27pm
catalyst-soul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 3:27pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Dec 17, 2024 3:27pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 3:27pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 3:27pm

@apledger apledger changed the base branch from main to soul/main December 15, 2024 23:22
@apledger apledger force-pushed the ap/slideshow-variables branch 2 times, most recently from 4b50c4f to e715906 Compare December 15, 2024 23:33
@apledger apledger force-pushed the ap/slideshow-variables branch from e715906 to 2fe6010 Compare December 16, 2024 17:30
@apledger apledger force-pushed the ap/slideshow-variables branch from 2fe6010 to cf077d2 Compare December 16, 2024 19:30
migueloller
migueloller approved these changes Dec 16, 2024
View reviewed changes
core/app/[locale]/layout.tsx
<html lang={locale}>
<body className={`${inter.variable} ${dm_serif_text.variable} ${roboto_mono.variable}`}>
<html
className={clsx(inter.variable, dm_serif_text.variable, roboto_mono.variable)}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: do we really need clsx here? 🙄

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk we just never string interpolate classes like that anywhere so I changed it to be consistent

@apledger apledger force-pushed the ap/slideshow-variables branch from cf077d2 to a0305c8 Compare December 17, 2024 15:25
@apledger apledger merged commit 2e01b7d into soul/main Dec 17, 2024
12 of 14 checks passed
@apledger apledger deleted the ap/slideshow-variables branch December 17, 2024 15:27
@github-actions GitHub Actions
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-nh4e13u1h-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 98
🟢 Accessibility 92
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 84
🟢 Accessibility 92
🟢 Best practices 100
🟠 SEO 83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@migueloller migueloller migueloller approved these changes

@jorgemoya jorgemoya Awaiting requested review from jorgemoya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apledger @migueloller