Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run pnpm lint -- --fix #1736

Merged
merged 1 commit into from
Dec 11, 2024
Merged

chore: run pnpm lint -- --fix #1736

merged 1 commit into from
Dec 11, 2024

Conversation

migueloller
Copy link
Collaborator

What/Why?

Fixes ESLint warnings.

Testing

Ran pnpm lint locally, CI should pass now.

@migueloller migueloller requested a review from a team as a code owner December 11, 2024 03:54
Copy link

changeset-bot bot commented Dec 11, 2024

⚠️ No Changeset found

Latest commit: b8689da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 3:57am
catalyst-soul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 3:57am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Dec 11, 2024 3:57am
catalyst-au ⬜️ Ignored (Inspect) Dec 11, 2024 3:57am
catalyst-uk ⬜️ Ignored (Inspect) Dec 11, 2024 3:57am

@migueloller migueloller changed the base branch from main to soul/main December 11, 2024 03:54
@migueloller migueloller changed the title Miguel/lint chore: run pnpm lint -- --fix Dec 11, 2024
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-kyonfkg0g-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 98
🟠 Accessibility 78
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 86
🟠 Accessibility 78
🟢 Best practices 100
🟠 SEO 83

@jorgemoya jorgemoya merged commit 31a7abd into soul/main Dec 11, 2024
13 of 15 checks passed
@jorgemoya jorgemoya deleted the miguel/lint branch December 11, 2024 14:43
jorgemoya pushed a commit that referenced this pull request Dec 12, 2024
jorgemoya pushed a commit that referenced this pull request Dec 12, 2024
chanceaclark pushed a commit that referenced this pull request Dec 12, 2024
jorgemoya pushed a commit that referenced this pull request Jan 3, 2025
jorgemoya pushed a commit that referenced this pull request Jan 3, 2025
jorgemoya pushed a commit that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants