Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): remove recaptcha fields in the account area #1729

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

chanceaclark
Copy link
Contributor

What/Why?

Removes the ReCaptcha validation from actions related to your account. ReCaptcha was needed for BigCommerce headless stores using client-side tokens, however we are using server side auth so it's no longer needed for pages that a customer is logged in for.

Testing

Screenshot 2024-12-10 at 10 49 48
Screenshot 2024-12-10 at 10 49 57
Screenshot 2024-12-10 at 10 50 04
Screenshot 2024-12-10 at 10 50 10

@chanceaclark chanceaclark requested a review from a team as a code owner December 10, 2024 15:50
Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: 7c54bb4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 4:02pm
catalyst-soul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 4:02pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Dec 10, 2024 4:02pm
catalyst-au ⬜️ Ignored (Inspect) Dec 10, 2024 4:02pm
catalyst-uk ⬜️ Ignored (Inspect) Dec 10, 2024 4:02pm

@chanceaclark chanceaclark added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit d52affe Dec 10, 2024
16 of 18 checks passed
@chanceaclark chanceaclark deleted the feat/remove-account-recaptcha branch December 10, 2024 17:28
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-oq2wxk1d1-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 83
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 88
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants